Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial data: Sanitise the spaceflights data to remove real countries and replace with fictional locations #2008

Closed
stichbury opened this issue Nov 9, 2022 · 10 comments
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation

Comments

@stichbury
Copy link
Contributor

It would make sense to change the spaceflights data slightly to keep the example completely fictional. Let's revise the locations and any other information that looks to be "genuine" since it isn't (it's completely fabricated) and shouldn't appear to be realistic in any way.

@stichbury
Copy link
Contributor Author

We could also reduce the size of the data perhaps. As @noklam mentions

As a starter that it get used in demo and testing, it takes a considerate of time to run the pipeline. For example in the Kedro bootcamp I see demoing catalog.load("shuttles") takes like 15-20 seconds and is a bit awkward for demo purpose.

@merelcht
Copy link
Member

merelcht commented Oct 3, 2023

We could also reduce the size of the data perhaps. As @noklam mentions

As a starter that it get used in demo and testing, it takes a considerate of time to run the pipeline. For example in the Kedro bootcamp I see demoing catalog.load("shuttles") takes like 15-20 seconds and is a bit awkward for demo purpose.

I've created a separate ticket for this: #3109

@ggermade
Copy link

ggermade commented Oct 6, 2023

Working on this :) !

@Gundalai-Batkhuu
Copy link

Hi. Can I get assigned for this please? I'm a CS student and this is my first open-source contribution.

@stichbury
Copy link
Contributor Author

stichbury commented Oct 12, 2023

Welcome @Gundalai-Batkhuu! You'd be very welcome, but before you dig in, let's see how @ggermade is getting on as they have posted above that they're working on this.

@ggermade
Copy link

hello! I'm actually with this already, I have a branch with changes but have not opened a PR yet as I'm missing a crucial step: finding out if there's missing documentation referencing the country name changes, so I can address them too

@Gundalai-Batkhuu
Copy link

No worries. I'll have a look at another issue.

@stichbury
Copy link
Contributor Author

Hi @ggermade just wanted to check how this is going for you? Anything we can help with?

@stichbury
Copy link
Contributor Author

Hi @ggermade This is the final call for contributions for October 2023. Please let us have any PRs you have in flight for Hacktoberfest before the end of the day!

@astrojuanlu
Copy link
Member

This is an old issue and, apart from some interest during Hacktoberfest, not much has happened. I'm closing for now.

@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
Archived in project
Development

No branches or pull requests

5 participants