Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2783] Decide how to declare the explicit dependency between micro-packages #1478

Closed
yetudada opened this issue Apr 25, 2022 · 2 comments

Comments

@yetudada
Copy link
Contributor

(transfer from Jira, created by @lorenabalan)

Once all the imports in (issue above) are converted and everything is packaged up, there's a chance some micro-packages depend on each other. Following the same example of

[tool.kedro.pipeline.package]
"pipelines.alpha" = {alias = beta}
"pipelines.alpha.utils" = {alias = sigma}
"other_package" = {alias = utilities, destination = "dist/libraries"}

beta could be importing something from other_package and therefore there's a dependency between the two, that's very likely not expressed in the modular pipeline's requirements.txt. How do we make sure this link is captured? In the metadata of the resulting source distribution of beta? In the contents of the distribution, i.e. packaged together? Should other_package come as source code or directly as wheel?

@astrojuanlu
Copy link
Member

Aside from the fact that we're to assess the micropackaging workflow at some point, I wonder if this whole cross-dependency functionality is worth exploring. I'm voting to close this issue at least for now.

@merelcht
Copy link
Member

Agree on closing this for now too. We haven't had any questions about this from users.

@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants