From d085290e1808102be5a0bd34e8c15a005532ebd0 Mon Sep 17 00:00:00 2001 From: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com> Date: Tue, 16 Jan 2024 15:02:32 +0000 Subject: [PATCH 1/2] Ensure the tools example selection uses the same starter version as kedro (#3504) * Update starters.py Signed-off-by: Sajid Alam * lint Signed-off-by: Sajid Alam --------- Signed-off-by: Sajid Alam --- kedro/framework/cli/starters.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kedro/framework/cli/starters.py b/kedro/framework/cli/starters.py index e0ff762589..8f37ac16f3 100644 --- a/kedro/framework/cli/starters.py +++ b/kedro/framework/cli/starters.py @@ -739,15 +739,20 @@ def _make_cookiecutter_args_and_fetch_template( if "PySpark" in tools and "Kedro Viz" in tools: # Use the spaceflights-pyspark-viz starter if both PySpark and Kedro Viz are chosen. cookiecutter_args["directory"] = "spaceflights-pyspark-viz" + # Ensures we use the same tag version of kedro for kedro-starters + cookiecutter_args["checkout"] = version elif "PySpark" in tools: # Use the spaceflights-pyspark starter if only PySpark is chosen. cookiecutter_args["directory"] = "spaceflights-pyspark" + cookiecutter_args["checkout"] = version elif "Kedro Viz" in tools: # Use the spaceflights-pandas-viz starter if only Kedro Viz is chosen. cookiecutter_args["directory"] = "spaceflights-pandas-viz" + cookiecutter_args["checkout"] = version elif example_pipeline: # Use spaceflights-pandas starter if example was selected, but PySpark or Viz wasn't cookiecutter_args["directory"] = "spaceflights-pandas" + cookiecutter_args["checkout"] = version else: # Use the default template path for non PySpark, Viz or example options: starter_path = template_path From 2dd34b40e73edcd611b079968e41de9ceec5401f Mon Sep 17 00:00:00 2001 From: Merel Theisen <49397448+merelcht@users.noreply.github.com> Date: Tue, 16 Jan 2024 18:12:48 +0000 Subject: [PATCH 2/2] Remove Andrew Mackay from current maintainers and add to past maintainers (#3516) Signed-off-by: Merel Theisen --- docs/source/contribution/technical_steering_committee.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/contribution/technical_steering_committee.md b/docs/source/contribution/technical_steering_committee.md index 88ce30b8c9..f97586d45a 100644 --- a/docs/source/contribution/technical_steering_committee.md +++ b/docs/source/contribution/technical_steering_committee.md @@ -56,7 +56,6 @@ We look for commitment markers who can do the following: | Name | Organisation | |----------------------------------------------------------|---------------------------------------------------------------------------------------- | | [Ahdra Merali](https://github.com/AhdraMeraliQB) | [QuantumBlack, AI by McKinsey](https://www.mckinsey.com/capabilities/quantumblack) | -| [Andrew Mackay](https://github.com/Mackay031) | [QuantumBlack, AI by McKinsey](https://www.mckinsey.com/capabilities/quantumblack) | | [Ankita Katiyar](https://github.com/ankatiyar) | [QuantumBlack, AI by McKinsey](https://www.mckinsey.com/capabilities/quantumblack) | | [Antony Milne](https://github.com/antonymilne) | [QuantumBlack, AI by McKinsey](https://www.mckinsey.com/capabilities/quantumblack) | | [Deepyaman Datta](https://github.com/deepyaman) | [Claypot AI](https://www.claypot.ai) | @@ -87,6 +86,7 @@ Kedro was originally designed by [Aris Valtazanos](https://github.com/arisvqb) a Former core team members with significant contributions include [Amanda Koh](https://github.com/amandakys), +[Andrew Mackay](https://github.com/Mackay031), [Andrii Ivaniuk](https://github.com/andrii-ivaniuk), [Anton Kirilenko](https://github.com/Flid), [Cvetanka Nechevska](https://github.com/cvetankanechevska),