Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kedro-telemetry: Add Integration tests to ensure telemetry event sends only once per command #770

Closed
DimedS opened this issue Jul 19, 2024 · 0 comments · Fixed by #771
Closed

kedro-telemetry: Add Integration tests to ensure telemetry event sends only once per command #770

DimedS opened this issue Jul 19, 2024 · 0 comments · Fixed by #771
Assignees
@DimedS
Labels
telemetry
Milestone
Telemetry opt-out

Comments

@DimedS
Copy link
Contributor

DimedS commented Jul 19, 2024

Description

Following the PR #766, we now send only one Heap event per command, rather than three as previously. We have separated the integration tests to verify this behavior, which will be addressed in the current issue. A draft solution is provided in the linked PR.
@DimedS DimedS added this to the Telemetry opt-out milestone Jul 19, 2024
@DimedS DimedS linked a pull request Jul 19, 2024 that will close this issue
feat(telemetry): add integration tests #771
Merged
4 tasks
@DimedS DimedS mentioned this issue Jul 19, 2024
Merged
4 tasks
@merelcht merelcht mentioned this issue Jul 22, 2024
Closed
5 tasks
@DimedS DimedS mentioned this issue Aug 23, 2024
Open
@merelcht merelcht changed the title kedro-telemetry: Add Integration tests to ensure telemetry event sends only once per command kedro-telemetry: Add Integration tests to ensure telemetry event sends only once per command Aug 27, 2024
@merelcht merelcht moved this to To Do in Kedro Framework Sep 2, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimedS DimedS

Labels
telemetry
Projects
Kedro Framework
Status: Done
Milestone
Telemetry opt-out
Development

Successfully merging a pull request may close this issue.

feat(telemetry): add integration tests kedro-org/kedro-plugins
2 participants
@noklam @DimedS