From b07a57ea485c11d8e5eba6ae1286cec908cb8ef6 Mon Sep 17 00:00:00 2001
From: Deepyaman Datta <deepyaman.datta@utexas.edu>
Date: Tue, 28 Mar 2023 11:25:00 -0400
Subject: [PATCH] build(datasets): add the missing `snowflake` extra (#148)

* build(datasets): add the missing `snowflake` extra

* Use `filesystem` instead of `fs` to satisfy pylint
---
 .../kedro_datasets/spark/spark_dataset.py     |  6 +--
 kedro-datasets/setup.py                       | 37 ++++++++++---------
 2 files changed, 22 insertions(+), 21 deletions(-)

diff --git a/kedro-datasets/kedro_datasets/spark/spark_dataset.py b/kedro-datasets/kedro_datasets/spark/spark_dataset.py
index aad2a5a90..166c921cc 100644
--- a/kedro-datasets/kedro_datasets/spark/spark_dataset.py
+++ b/kedro-datasets/kedro_datasets/spark/spark_dataset.py
@@ -318,9 +318,9 @@ def __init__(  # pylint: disable=too-many-arguments
                 glob_function = partial(_dbfs_glob, dbutils=dbutils)
                 exists_function = partial(_dbfs_exists, dbutils=dbutils)
         else:
-            fs = fsspec.filesystem(fs_prefix.strip("://"), **credentials)
-            exists_function = fs.exists
-            glob_function = fs.glob
+            filesystem = fsspec.filesystem(fs_prefix.strip("://"), **credentials)
+            exists_function = filesystem.exists
+            glob_function = filesystem.glob
 
         super().__init__(
             filepath=path,
diff --git a/kedro-datasets/setup.py b/kedro-datasets/setup.py
index 1c6492c16..01c40f73f 100644
--- a/kedro-datasets/setup.py
+++ b/kedro-datasets/setup.py
@@ -41,8 +41,8 @@ def _collect_requirements(requires):
 geopandas_require = {
     "geopandas.GeoJSONDataSet": ["geopandas>=0.6.0, <1.0", "pyproj~=3.0"]
 }
-matplotlib_require = {"matplotlib.MatplotlibWriter": ["matplotlib>=3.0.3, <4.0"]}
 holoviews_require = {"holoviews.HoloviewsWriter": ["holoviews~=1.13.0"]}
+matplotlib_require = {"matplotlib.MatplotlibWriter": ["matplotlib>=3.0.3, <4.0"]}
 networkx_require = {"networkx.NetworkXDataSet": ["networkx~=2.4"]}
 pandas_require = {
     "pandas.CSVDataSet": [PANDAS],
@@ -63,26 +63,23 @@ def _collect_requirements(requires):
     "pandas.GenericDataSet": [PANDAS],
 }
 pillow_require = {"pillow.ImageDataSet": ["Pillow~=9.0"]}
-polars_require = {"polars.CSVDataSet": [POLARS],}
-video_require = {
-    "video.VideoDataSet": ["opencv-python~=4.5.5.64"]
-}
 plotly_require = {
     "plotly.PlotlyDataSet": [PANDAS, "plotly>=4.8.0, <6.0"],
     "plotly.JSONDataSet": ["plotly>=4.8.0, <6.0"],
 }
+polars_require = {"polars.CSVDataSet": [POLARS],}
 redis_require = {"redis.PickleDataSet": ["redis~=4.1"]}
+snowflake_require = {
+    "snowflake.SnowparkTableDataSet": ["snowflake-snowpark-python~=1.0.0", "pyarrow~=8.0"]
+}
 spark_require = {
     "spark.SparkDataSet": [SPARK, HDFS, S3FS],
     "spark.SparkHiveDataSet": [SPARK, HDFS, S3FS],
     "spark.SparkJDBCDataSet": [SPARK, HDFS, S3FS],
     "spark.DeltaTableDataSet": [SPARK, HDFS, S3FS, "delta-spark~=1.0"],
 }
-snowpark_require = {
-    "snowflake.SnowparkTableDataSet": ["snowflake-snowpark-python~=1.0.0", "pyarrow~=8.0"]
-}
 svmlight_require = {"svmlight.SVMLightDataSet": ["scikit-learn~=1.0.2", "scipy~=1.7.3"]}
-tensorflow_required = {
+tensorflow_require = {
     "tensorflow.TensorflowModelDataset": [
         # currently only TensorFlow V2 supported for saving and loading.
         # V1 requires HDF5 and serialises differently
@@ -91,6 +88,9 @@ def _collect_requirements(requires):
         "tensorflow-macos~=2.0; platform_system == 'Darwin' and platform_machine == 'arm64'",
     ]
 }
+video_require = {
+    "video.VideoDataSet": ["opencv-python~=4.5.5.64"]
+}
 yaml_require = {"yaml.YAMLDataSet": [PANDAS, "PyYAML>=4.2, <7.0"]}
 
 extras_require = {
@@ -109,35 +109,36 @@ def _collect_requirements(requires):
         "myst-parser~=0.17.2",
     ],
     "geopandas": _collect_requirements(geopandas_require),
-    "matplotlib": _collect_requirements(matplotlib_require),
     "holoviews": _collect_requirements(holoviews_require),
+    "matplotlib": _collect_requirements(matplotlib_require),
     "networkx": _collect_requirements(networkx_require),
     "pandas": _collect_requirements(pandas_require),
     "pillow": _collect_requirements(pillow_require),
-    "polars": _collect_requirements(polars_require),
-    "video": _collect_requirements(video_require),
     "plotly": _collect_requirements(plotly_require),
+    "polars": _collect_requirements(polars_require),
     "redis": _collect_requirements(redis_require),
+    "snowflake": _collect_requirements(snowflake_require),
     "spark": _collect_requirements(spark_require),
     "svmlight": _collect_requirements(svmlight_require),
-    "tensorflow": _collect_requirements(tensorflow_required),
+    "tensorflow": _collect_requirements(tensorflow_require),
+    "video": _collect_requirements(video_require),
     "yaml": _collect_requirements(yaml_require),
     **api_require,
     **biosequence_require,
     **dask_require,
     **geopandas_require,
-    **matplotlib_require,
     **holoviews_require,
+    **matplotlib_require,
     **networkx_require,
     **pandas_require,
     **pillow_require,
-    **polars_require,
-    **video_require,
     **plotly_require,
+    **polars_require,
+    **snowflake_require,
     **spark_require,
-    **snowpark_require,
     **svmlight_require,
-    **tensorflow_required,
+    **tensorflow_require,
+    **video_require,
     **yaml_require,
 }