Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sample is not compatible with the latest ScaledObject CRD #5

Open
ivanRylach opened this issue Nov 26, 2019 · 2 comments
Open

The sample is not compatible with the latest ScaledObject CRD #5

ivanRylach opened this issue Nov 26, 2019 · 2 comments

Comments

@ivanRylach
Copy link

When following the README, rabbitmq-consumer does not scale to 0. keda-operator prints following errors:

ScaledObject.keda.k8s.io "rabbitmq-consumer" is invalid: []: Invalid value: map[string]interface {}{"apiVersion":"keda.k8s.io/v1alpha1", "kind":"ScaledObject", "metadata":map[string]interface {}{"annotations":map[string]interface {}{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"keda.k8s.io/v1alpha1\",\"kind\":\"ScaledObject\",\"metadata\":{\"annotations\":{},\"labels\":{\"deploymentName\":\"rabbitmq-consumer\"},\"name\":\"rabbitmq-consumer\",\"namespace\":\"default\"},\"spec\":{\"cooldownPeriod\":10,\"maxReplicaCount\":30,\"pollingInterval\":5,\"scaleTargetRef\":{\"deploymentName\":\"rabbitmq-consumer\"},\"triggers\":[{\"metadata\":{\"host\":\"RabbitMqHost\",\"queueLength\":\"5\",\"queueName\":\"hello\"},\"type\":\"rabbitmq\"}]}}\n"}, "creationTimestamp":"2019-11-26T03:18:36Z", "finalizers":[]interface {}{"finalizer.keda.k8s.io"}, "generation":1, "labels":map[string]interface {}{"deploymentName":"rabbitmq-consumer"}, "name":"rabbitmq-consumer", "namespace":"default", "resourceVersion":"35693", "uid":"6eed936f-0ffb-11ea-80f3-025000000001"}, "spec":map[string]interface {}{"cooldownPeriod":10, "maxReplicaCount":30, "pollingInterval":5, "scaleTargetRef":map[string]interface {}{"deploymentName":"rabbitmq-consumer"}, "triggers":[]interface {}{map[string]interface {}{"metadata":map[string]interface {}{"host":"RabbitMqHost", "queueLength":"5", "queueName":"hello"}, "type":"rabbitmq"}}}, "status":map[string]interface {}{"externalMetricNames":[]interface {}{"queueLength"}}}: validation failure list:
status.currentReplicas in body is required
status.desiredReplicas in body is required

The latest ScaledObject CRD has the following ScaledObjectStatus definition

"status": {
	"description": "ScaledObjectStatus is the status for a ScaledObject resource",
	"properties": { ... },
	"required": [
		"currentReplicas",
		"desiredReplicas"
	],
	"type": "object"
}
@du2016
Copy link

du2016 commented Nov 26, 2019

i have the same problem

@jeffhollan
Copy link
Member

We had an issue in our helm chart and tutorial in November we patched. I assume this is resolved? Let me know if not. Just tested end-to-end and seemed to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants