Create make release target to update versions #610
Conversation
RELEASE-PROCESS.MD
Outdated
| https://github.com/kedacore/keda/blob/master/deploy/24-metrics-api_service.yaml | ||
|
|
||
| Commit these changes. | ||
| * Set the `IMAGE_TAG` value to the next version, eg 1.2.0. |
There was a problem hiding this comment.
I am thinking whether we shouldn't rename variable IMAGE_TAG to VERSION as it is more correct description of what it actually is?
If we do so, we will need to modify Readme and release script a little bit.
WDYT?
There was a problem hiding this comment.
Just wondering, during the release process, when we change the yaml files, shouldn't it also need to commit those files too? To reflect in git?
Also should the release process also include build and publish?
There was a problem hiding this comment.
Yes, there is a note about commiting the changes in the document.
And for the build and publish part, I'd keep it as it is, as it is handled by the github release workflow, if I am not mistaken
There was a problem hiding this comment.
Personally, I would prefer VERSION as it is used for both versioning files and 'versioning' image tags.
I'll change it for now and if someone feels strongly against it, I can revert then :)
| run: make VERSION=$VERSION publish |
There was a problem hiding this comment.
I wonder if this is needed? :)
There was a problem hiding this comment.
Hm, I assume you would only ever trigger this flow after running make release? If so, I can remove the tag from this command.
There was a problem hiding this comment.
Actually, I think this will still be needed as make release won't replace the VERSION inside Makefile. So you'll still need to specify the version, otherwise it will publish the default of master.
There was a problem hiding this comment.
The change looks good! Thanks @Cottonglow and @zroubalik for the review
The new target in the Makefile replaces the versions in the yaml files for both the labels and the images as well as the version in version.go.
Happy for suggestions on how to improve!
Fixes #580