remove kustomize commonLabels #5888
Merged
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e internal |
zroubalik
reviewed
Jun 18, 2024
|
/run-e2e internal |
zroubalik
reviewed
Jun 24, 2024
There was a problem hiding this comment.
@therealdwright Thanks for the contribution, one last thing, could you please update Changelog (Unreleased/Other section) and link the issue there? We can proceed and merge this one then, Thanks!
therealdwright
force-pushed
the
remove-commonlabels
branch
from
8dcf29b
to
58917dd
Compare
No problems, that's done |
Signed-off-by: Daniel Wright <danielwright@bitgo.com>
therealdwright
force-pushed
the
remove-commonlabels
branch
from
58917dd
to
5676893
Compare
uucloud
pushed a commit
to uucloud/keda
that referenced
this pull request
Jul 11, 2024
Signed-off-by: Daniel Wright <danielwright@bitgo.com> Signed-off-by: uucloud <uucloud@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Wright dan@dwright.io
Remove
commonLabelsin favour of the more modern kustomize approach.Checklist
Fixes #5887