feat(gcp-stackdriver): handling value if no timeseries is return #5345
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: VAN KELST Baptiste <baptistevk@gmail.com>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
Signed-off-by: VAN KELST Baptiste <baptistevk@gmail.com>
1 task
JorTurFer
reviewed
Jan 3, 2024
JorTurFer
reviewed
Jan 3, 2024
|
/run-e2e gcp |
Signed-off-by: VAN KELST Baptiste <baptistevk@gmail.com>
lindmin
commented
Jan 3, 2024
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: lindmin <baptistevk@gmail.com>
|
/run-e2e gcp |
JorTurFer
approved these changes
Jan 3, 2024
zroubalik
approved these changes
Jan 3, 2024
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
…acore#5345) * feat(gcp-stackdriver): handling value if no timeseries is return Signed-off-by: VAN KELST Baptiste <baptistevk@gmail.com> * fix bad space Signed-off-by: VAN KELST Baptiste <baptistevk@gmail.com> * update changelog Signed-off-by: VAN KELST Baptiste <baptistevk@gmail.com> * Update pkg/scalers/gcp_stackdriver_scaler.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: lindmin <baptistevk@gmail.com> --------- Signed-off-by: VAN KELST Baptiste <baptistevk@gmail.com> Signed-off-by: lindmin <baptistevk@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Context: it's pretty common to see metric that have no value during some period that can be interpretate by 0.
So this pulling request adding an optional metadata
valueIfNull. This value (if not empty) that will be used if there is no timeseries return by the gcp monitoring query.Checklist
Fixes #
Relates to #
kedacore/keda-docs#1285