feat: Allow specifying Selenium Grid URL as secret #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows specifying the GraphQL URL used by the Selenium Grid Scaler to be specified in a TriggerAuthentication resource and thus pulled from a secret store. We are using Selenium Grid's basic authentication and needed to specify a username/password as part of the URL. Signed-off-by: JD Harrington <jd@jdharrington.net>
|
/run-e2e selenium* |
JorTurFer
reviewed
Oct 14, 2022
Ah, sorry! I could've sworn I amended my commit. Will do that now :) |
psi
force-pushed
the
selenium-grid-secret-url
branch
from
62ecbe4
to
b07b051
Compare
JorTurFer
previously approved these changes
Oct 14, 2022
JorTurFer
requested changes
Oct 14, 2022
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: JD Harrington <jd@jdharrington.net>
JorTurFer
approved these changes
Oct 14, 2022
|
/run-e2e selenium* |
1 task
4 tasks
26tanishabanik
pushed a commit
to 26tanishabanik/keda
that referenced
this pull request
Nov 1, 2022
* feat: Allow specifying Selenium Grid URL as secret This allows specifying the GraphQL URL used by the Selenium Grid Scaler to be specified in a TriggerAuthentication resource and thus pulled from a secret store. We are using Selenium Grid's basic authentication and needed to specify a username/password as part of the URL. Signed-off-by: JD Harrington <jd@jdharrington.net> * Add PR reference to CHANGELOG.md Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: JD Harrington <jd@jdharrington.net> Signed-off-by: JD Harrington <jd@jdharrington.net> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: 26tanishabanik <26tanishabanik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifying the GraphQL URL used by the Selenium Grid Scaler to be specified in a TriggerAuthentication resource and thus pulled from a secret store. We are using Selenium Grid's basic authentication and needed to specify a username/password as part of the URL.
Checklist
Fixes #
Relates to kedacore/keda-docs#959