Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure EventHub Scaler: don't expose connection string in metricName #2404

Merged
merged 3 commits into from
Jan 3, 2022
Merged

Azure EventHub Scaler: don't expose connection string in metricName #2404

merged 3 commits into from
Jan 3, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Dec 15, 2021 •
edited
Loading

Signed-off-by: jorturfer jorge_turrado@hotmail.es

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #2403

@JorTurFer
Use EventHubConsumerGroup instead of EventHubConnection
1ebd089 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner December 15, 2021 23:57
@JorTurFer
Update changelog
d631db1 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer added this to the v2.6.0 milestone Dec 16, 2021
@zroubalik zroubalik merged commit 705d9af into kedacore:main Jan 3, 2022
@JorTurFer JorTurFer deleted the eventhub_connection branch January 3, 2022 10:53
zroubalik added a commit to zroubalik/keda that referenced this pull request Jan 4, 2022
@zroubalik
Azure EventHub Scaler: don't expose connection string in metricName (k…
80a491e 
…edacore#2404)


Signed-off-by: jorturfer <jorge_turrado@hotmail.es>

Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
zroubalik added a commit that referenced this pull request Jan 4, 2022
@zroubalik
Azure EventHub Scaler: don't expose connection string in metricName (#…
60d1e8f 
…2404)


Signed-off-by: jorturfer <jorge_turrado@hotmail.es>

Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
alex60217101990 pushed a commit to dysnix/keda that referenced this pull request Jan 10, 2022
@zroubalik @alex60217101990
Azure EventHub Scaler: don't expose connection string in metricName (k…
690e87b 
…edacore#2404)


Signed-off-by: jorturfer <jorge_turrado@hotmail.es>

Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: alex60217101990 <alex6021710@gmail.com>
alex60217101990 pushed a commit to dysnix/keda that referenced this pull request Jan 10, 2022
@zroubalik @alex60217101990
Azure EventHub Scaler: don't expose connection string in metricName (k…
e71e43b 
…edacore#2404)


Signed-off-by: jorturfer <jorge_turrado@hotmail.es>

Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: alex60217101990 <alex6021710@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.

Azure EventHub Scaler: don't expose connection string in metricName
2 participants
@JorTurFer @zroubalik