Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenStack Swift scaler #1652

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

pdominguite
Copy link
Contributor

@pdominguite pdominguite commented Mar 3, 2021

Signed-off-by: Pedro Felipe Dominguite (p.dominguite@sidi.org.br)

Changes

  • The swiftURL is now an optional parameter since it can be retrieved from the catalog.
  • The optional parameter regionName was added.
  • Now, the Keystone module can retrieve the service URL dynamically for any OpenStack service, by searching into the OpenStack catalog within the given authorization scope.
  • Add serviceTypes helper which retrieves all the service types historically used by an OpenStack project.
  • Update OpenStack Swift scaler unit tests

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • Tests have been added
  • A PR is opened to update the documentation (#386)
  • Changelog has been updated

The swiftURL is now optional since it can be retrieved from the catalog.
The optional parameter regionName was added.

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

* Update Keystone helper

Now, the Keystone module can retrieve the service URL dynamically for any OpenStack service, by searching into the OpenStack catalog within the given authorization scope.

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

* Add serviceTypes util

This helper retrieves all the service types historically used by an OpenStack project.

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

* Add OpenStack region option

It specifies the region name where the service is available.
It can be used to retrieve the correct service URL from the catalog.

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

* Update OpenStack Swift scaler unit tests

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

* Update CHANGELOG.md

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 1593493 into kedacore:main Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants