Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Google Cloud Platform (GCP) Stackdriver scaler #754

Open
tomkerkhove opened this issue Apr 17, 2020 · 9 comments
Open

Introduce Google Cloud Platform (GCP) Stackdriver scaler #754

tomkerkhove opened this issue Apr 17, 2020 · 9 comments
Assignees
Labels
feature All issues for new features that have been committed to gcp All issues concerning integration with GCP help wanted Looking for support from community scaler scaler-proposal stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@tomkerkhove
Copy link
Member

Since you can only run one custom metric adapter we should introduce a Google Cloud Platform (GCP) Stackdriver scaler which is compatible with Stackdriver Adapter:

  • Scaler Source: Google Cloud Platform (GCP) Stackdriver
  • How do you want to scale: See adapter, but might align over multiple iterations
  • Authentication: See adapter, but might align over multiple iterations
@tomkerkhove tomkerkhove added needs-discussion scaler gcp All issues concerning integration with GCP labels Apr 17, 2020
@zroubalik
Copy link
Member

Interesting idea! We should keep in mind that Stackdriver exposes both Custom Metrics and External Metrics. KEDA is using/exposing just External Metrics.

@frank-berlin
Copy link

Other way would to extent the keda keda-metrics-adapter in a way, that all requests, what he can't handle get transparent proxied to another metrics-adapter.
With this there would be a workaround to the limitation of k8s metrics api .
This also allow a smooth migration on existing cluster with hpa usage to use keda.

@tomkerkhove
Copy link
Member Author

Let's do both!

Would you mind opening an issue for your idea @frank-berlin?

@frank-berlin
Copy link

done see #763

@yolossn
Copy link

yolossn commented Mar 13, 2021

@tomkerkhove I would like to work on this. Can you assign this to me?

@tomkerkhove
Copy link
Member Author

Great to hear, thank you!

@tomkerkhove tomkerkhove added the help wanted Looking for support from community label Sep 28, 2021
@stale
Copy link

stale bot commented Nov 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Nov 27, 2021
@zroubalik zroubalik added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Nov 27, 2021
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Nov 27, 2021
@tomkerkhove
Copy link
Member Author

Any update on this @yolossn?

@tomkerkhove tomkerkhove added feature All issues for new features that have been committed to and removed Hacktoberfest labels Nov 29, 2021
@xSAVIKx
Copy link

xSAVIKx commented May 14, 2024

We currently hit a wall where we were trying to use custom metrics adapter and spent a couple of days realizing we also use KEDA and that's why we can't rely on the other one 😄

Would really appreciate some update, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature All issues for new features that have been committed to gcp All issues concerning integration with GCP help wanted Looking for support from community scaler scaler-proposal stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Status: To Do
Development

No branches or pull requests

5 participants