Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for missing data in Dynatrace scaler #6097

Open
zip-chanko opened this issue Aug 20, 2024 · 5 comments
Open

Default value for missing data in Dynatrace scaler #6097

zip-chanko opened this issue Aug 20, 2024 · 5 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity

Comments

@zip-chanko
Copy link

zip-chanko commented Aug 20, 2024

Proposal

A parameter for a scaler which fallbacks to a default value when the query returns no value.

Example: The fallbackThreshold parameter which fallbacks the value to 10 when the query returns no value.

triggers:
  - type: dynatrace
    metadata:
      host: https://dummy-instance.live.dynatrace.com/
      metricSelector: 'MyCustomEvent:filter(eq("someProperty","someValue")):count:splitBy("dt.entity.process_group"):fold'
      threshold: "1000"
      fallbackThreshold: "10"

Use-Case

As described in #6054, Keda will show a warning KEDAScalerFailed if the query return no value.

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@zip-chanko zip-chanko added feature-request All issues for new features that have not been committed to needs-discussion labels Aug 20, 2024
@JorTurFer
Copy link
Member

Hello
Does Dynatrace support default values within the query?

@zip-chanko
Copy link
Author

Something that I'm not aware of. This is a general idea which applies to all scalers where a trigger could have a fallback value?

@JorTurFer
Copy link
Member

No no, I'm asking about if Dynatrace query language supports default values as part of the query. For example, PromQL does support setting default values

@rickbrouwer
Copy link
Contributor

@zip-chanko
The default transformation replaces null values in the payload with the specified value. Is this something you can use?

Copy link

stale bot commented Oct 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity
Projects
Status: To Triage
Development

No branches or pull requests

3 participants