You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue involves cleaning up the IBM MQ scaler code and ensuring the documentation is accurate.
The queueManager parameter is currently checked to see if it's filled, but it's not used elsewhere in the code. This unused code will be removed.
Additionally, the parameter tlsDisabled is used in the code in relation to CreateHTTPClient. However, all other scalers use the parameter unsafeSsl. To maintain consistency between other scalers, we are making changes, as unsafeSsl already handles this functionality. tls will still be supported. My proposal is to tag the tls parameter with deprecated=use unsafeSsl instead in version 2.18 and remove the deprecated code.
The current documentation states that the default queueDepth is 5, while the code default is 20. The documentation will be updated to reflect the correct default value of 20, aligning it with the code.
Finally, there will be some minor adjustments to the documentation.
Use-Case
You are required to specify a queueManager, while it is not used. That is unnecessary configuration.
tlsDisabled has never worked. The code looks at tls and it will be therefore always false, when you followed the documentation. But because the code now also contains unsafeSsl, we want to use this standard because other scalers use unsafeSsl for the same functionality.
Is this a feature you are interested in implementing yourself?
Yes
Anything else?
No response
The text was updated successfully, but these errors were encountered:
Proposal
This issue involves cleaning up the IBM MQ scaler code and ensuring the documentation is accurate.
The
queueManager
parameter is currently checked to see if it's filled, but it's not used elsewhere in the code. This unused code will be removed.Additionally, the parameter
tlsDisabled
is used in the code in relation toCreateHTTPClient
. However, all other scalers use the parameterunsafeSsl
. To maintain consistency between other scalers, we are making changes, asunsafeSsl
already handles this functionality.tls
will still be supported. My proposal is to tag thetls
parameter withdeprecated=use unsafeSsl instead
in version 2.18 and remove the deprecated code.The current documentation states that the default
queueDepth
is5
, while the code default is20
. The documentation will be updated to reflect the correct default value of20
, aligning it with the code.Finally, there will be some minor adjustments to the documentation.
Use-Case
You are required to specify a
queueManager
, while it is not used. That is unnecessary configuration.tlsDisabled
has never worked. The code looks attls
and it will be therefore alwaysfalse
, when you followed the documentation. But because the code now also containsunsafeSsl
, we want to use this standard because other scalers useunsafeSsl
for the same functionality.Is this a feature you are interested in implementing yourself?
Yes
Anything else?
No response
The text was updated successfully, but these errors were encountered: