Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow activationQueueLength (SQS) to respect in-flight Messages #5948

Closed
claudio-vellage opened this issue Jul 4, 2024 · 4 comments
Closed
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity

Comments

@claudio-vellage
Copy link

Proposal

We want to be able to tell KEDA to not kill the workers if the in-flight messages are above the activationQueueLength.

Use-Case

We have a special use-case, where we need to process a certain amount of messages, before we can eventually remove those messages from the queue. Therefore, we have a lot of in-flight messages, but unfortunately KEDA scales down our worker, before those in-flight messages are processed, leading to a lot of messages piling up in the dead letter queue. How can we achieve our goal, so that KEDA will consider the in-flight messages too for activationQueueLength or is it already the case and our issue is elsewhere? Let me know if you need more information about what exactly we are trying to achieve.

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@claudio-vellage claudio-vellage added feature-request All issues for new features that have not been committed to needs-discussion labels Jul 4, 2024
@tomkerkhove
Copy link
Member

Reasonable ask, we'll need to wait for somebody to contribute this.

@joebowbeer
Copy link
Contributor

@claudio-vellage asks:

How can we achieve our goal, so that KEDA will consider the in-flight messages too for activationQueueLength or is it already the case and our issue is elsewhere?

It is already the case unless you set scaleOnInFlight=false.

By default, scaleOnDelayed is false and scaleOnInFlight is true.

This means that both sources (normal + inflight) are counted.

Then the activationQueueLength is compared to whatever length is counted above.

https://github.com/kedacore/keda/blob/main/pkg/scalers/aws_sqs_queue_scaler.go#L137

Copy link

stale bot commented Oct 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 5, 2024
Copy link

stale bot commented Oct 19, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity
Projects
None yet
Development

No branches or pull requests

3 participants