Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowcontrol needs to be allowed in Metrics Server with k8s 0.29.4 #5740

Closed
zroubalik opened this issue Apr 24, 2024 · 2 comments
Closed

Flowcontrol needs to be allowed in Metrics Server with k8s 0.29.4 #5740

zroubalik opened this issue Apr 24, 2024 · 2 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@zroubalik
Copy link
Member

zroubalik commented Apr 24, 2024

Proposal

We need to add following RBAC to the Cluster Role used by KEDA Metrics Server:

- apiGroups:
  - flowcontrol.apiserver.k8s.io
  resources:
  - flowschemas
  - prioritylevelconfigurations

To give more info about this role, it allows for setting priority and fairness to requests. It essentially rate limit certain requests in favor of others based on a user defined config. https://kubernetes.io/docs/concepts/cluster-administration/flow-control/

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

@zroubalik zroubalik added needs-discussion feature-request All issues for new features that have not been committed to labels Apr 24, 2024
This was referenced Apr 24, 2024
@zroubalik
Copy link
Member Author

zroubalik commented Apr 24, 2024

Fix in charts is missing

@JorTurFer
Copy link
Member

JorTurFer commented May 7, 2024

This isn't required anymore as they disabled the feature as default (and we won't use it for the moment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants