Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Server: klogr.New is deprecated use textlogger.NewLogger instead #5732

Closed
zroubalik opened this issue Apr 23, 2024 · 6 comments
Closed
Assignees
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers needs-discussion stale All issues that are marked as stale due to inactivity

Comments

@zroubalik
Copy link
Member

Proposal

var logger = klogr.New().WithName("keda_metrics_adapter")

cmd/adapter/main.go:58:14: SA1019: klogr.New is deprecated: this uses a custom, out-dated output format. Use textlogger.NewLogger instead. (staticcheck)
var logger = klogr.New().WithName("keda_metrics_adapter")

Let's migrate to the new interface, there might be some changes in the config/parameters etc.

It might also help with issues like: #5139

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response

@zroubalik zroubalik added good first issue Good for newcomers needs-discussion feature-request All issues for new features that have not been committed to labels Apr 23, 2024
@JorTurFer
Copy link
Member

I think that it's a good moment to unify all the loggers across components, operator uses zap IIRC, maybe can give a try but I think that custom-metrics-apiserver can be the blocker here

@guopeng0
Copy link
Contributor

Hi @zroubalik , I would like to work on this issue can you please assign it to me.

@zroubalik
Copy link
Member Author

@guopeng0 thanks!

Copy link

stale bot commented Jun 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jun 25, 2024
@zroubalik zroubalik removed the stale All issues that are marked as stale due to inactivity label Jun 25, 2024
Copy link

stale bot commented Aug 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Aug 27, 2024
Copy link

stale bot commented Sep 5, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers needs-discussion stale All issues that are marked as stale due to inactivity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants