Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate fallback configuration during admission process #5515

Closed
JorTurFer opened this issue Feb 16, 2024 · 2 comments · Fixed by #5629
Closed

Validate fallback configuration during admission process #5515

JorTurFer opened this issue Feb 16, 2024 · 2 comments · Fixed by #5629
Assignees
@guopeng0
Labels
feature All issues for new features that have been committed to good first issue Good for newcomers help wanted Looking for support from community

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Feb 16, 2024 •
edited
Loading

Proposal

Currently, fallback feature only supports AverageValue metrics type and it doesn't support CPU and Memory.
image

To prevent misconfigurations and confusions related with these limitations, we should include a validation for them during the admission process
@JorTurFer JorTurFer added help wanted Looking for support from community good first issue Good for newcomers feature All issues for new features that have been committed to labels Feb 16, 2024
This was referenced Feb 16, 2024
Closed
Closed
@guopeng0
Copy link
Contributor

guopeng0 commented Mar 20, 2024 •
edited
Loading

Hi @JorTurFer
I’m interested in the issue and would like to take on the task. Any guidance or suggestions on how to start? Excited to contribute to the project and help resolve this issue.

@JorTurFer
Copy link
Member Author

Thanks @guopeng0 ! ❤️

@guopeng0 guopeng0 mentioned this issue Mar 27, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guopeng0 guopeng0

Labels
feature All issues for new features that have been committed to good first issue Good for newcomers help wanted Looking for support from community
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: validate fallback configuration guopeng0/keda
2 participants
@JorTurFer @guopeng0