-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ScaledObject taking over existing HPAs with the same name while they are not managed by other ScaledObject #4457
Comments
This feature might enable the opportunity to create a "Migrator CLI" or similar that should replace the existing HPA yaml with a modified ScaledObject that should take over the previous resource. |
Is your main problem that the webhook is blocking it? Because you can also install it without webhook validation. Additionally, I believe we should allow you to turn off rules which are tracked in #4067 |
@tomkerkhove, the behaviors in the webhook are expected unless someone is trying to migrate their resources in their namespace. This is useful for multi-tenant clusters holding workloads for multiple teams so not all the teams need to perform the migration simultaneously. |
So would it help if you could:
That way you can create the SO next to your HPA and you can delete the HPA once the SO is created. Would that help? A migratory CLI could be another route but more work for something "trivial" which would only cover CPU/memory then? |
As discussed in standup, the current thinking is to:
Once that is the case, KEDA will:
|
Hi, any progress on this issue? Looks like PR still in draft mode |
Proposal
Support a new field such as
advanced.takeOverCurrentHpa
that should be able to skip validation webhook when the existing HPA that is being taken over does not have any metadata that indicates it's managed by another ScaledObjectname=foo
exists.name=foo
but also had setadvanced.takeOverCurrentHpa = true
.Use-Case
Supports drop-in migrations for companies using HPA that want to easily move existing resources with ScaledObjects.
Is this a feature you are interested in implementing yourself?
Maybe
Anything else?
No response
The text was updated successfully, but these errors were encountered: