Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Managed identity auth for Blob Storage checkpointing in Event Hub scaler #3569

Closed
andyatwork opened this issue Aug 19, 2022 · 3 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@andyatwork
Copy link
Contributor

andyatwork commented Aug 19, 2022

Proposal

Accessing the blob storage for Event Hubs requires a connection string to be supplied by means of triggers.metadata.storageConnectionFromEnv . azure_eventhub_checkpoint.go could be modified to pass the PodIdentity from EventHubInfo with the required account name and endpoint to enable pod identity based authentication.

Suggest to pass PodIdentity to ParseAzureStorageBlobConnection and add fields to trigger.metadata:

  • StorageAccountName - The name of the account

StorageEndpointSuffix is internally resolved from Azure's environment configuration for the specified cloud.

The fqdn blob storage uri is compiled from https://{StorageAccountName}.blob.{StorageEndpointSuffix}/ .

Use-Case

Allowing pod identities to be used consistently across Event Hub and Storage Accounts enables connection string free configurations and eliminates the need to manually manage a connection credential.

Anything else?

When using the above configuration together with a triggers.authenticationRef, the field storageConnectionFromEnv is no longer required.

To preserve back-compat, if storageConnectionFromEnv is provided, it will force connection string based authN for the blob storage account.

@andyatwork andyatwork added feature-request All issues for new features that have not been committed to needs-discussion labels Aug 19, 2022
@andyatwork
Copy link
Contributor Author

I'd be happy to contribute this feature to the project.

@tomkerkhove tomkerkhove changed the title Support PodIdentity authN for Blob Storage checkpointing in Event Hub scaler Support Managed identity auth for Blob Storage checkpointing in Event Hub scaler Aug 22, 2022
@stale
Copy link

stale bot commented Oct 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 21, 2022
@JorTurFer JorTurFer added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Oct 27, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Oct 27, 2022
@v-shenoy
Copy link
Contributor

v-shenoy commented Nov 4, 2022

Completed in #3573.

@v-shenoy v-shenoy closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants