-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide scaler for NATS Jetstream #2391
Comments
Hi @shaunc |
Thank you, @JorTurFer! I'm not familiar with the codebase, and have many things to do. That said, getting this working would simplify a number of other things (like having to maintain a Kafka cluster). If you could give some pointers/a checklist, I can investigate, and depending on how much work there is make some contributions if not the full feature. |
hi @shaunc , |
I can take this up in coming weeks |
Thanks!! |
Very good! ... (currently very busy :( ).... |
@goku321 do you have a plan or task board, and repository to contribute on? I think there are some people having the same interest in this. |
Hi @xgenvn I didn't plan anything yet. I believe it will be like any other scalers that we already have. I will start on this today/tomorrow and will try to keep you in loop. |
@goku321 I did a check on the scalers of STAN and a bit on the JetStream metrics endpoint. It seems there are many differences with |
@xgenvn I'm interested in being able to scale using JetStream metrics as well. Is this something that is being considered, if so what is the timeframe? Re the /jsz endpoint, which specific Nats server issue were you referencing. We might be willing to do some work here. |
@leopoldodonnell I've started working on the scaler. Will try my best to conclude it in a couple of weeks. And, yes the scaler will consider the JetStream metrics |
@goku321 No pressure (really) Just checking to see if you were able to make any progress towards a JetStream scaler? |
@leopoldodonnell @xgenvn Got delayed due to some pre-commit issues Here's the commit: goku321@126130b (Didn't test it yet) I'm not sure how accurate is Would really appreciate your input and help 🙂 |
@goku321 I will build it and have a look - its not my top priority, but I'd like to see this working and really appreciate that someone is giving it a try. |
Any updates? |
Let's see where @goku321 is at and if he wants to contribute it. |
@gcameo @tomkerkhove I still want to contribute. I had already started with the tests couple of weeks back but a bit caught up with production deployments these days. Will try to wrap up in the coming weekends or so. Appreciate your patience :) |
hey @goku321 |
Hi @JorTurFer In the process of testing the scaler. Will try to create a PR by today. |
Hi all. Can anyone from this thread with JetStream experience please review this scaler (#3468)? Would really appreciate the help :) |
Proposal
Currently keda supports NATS streaming. However, NATS Streaming has been deprecated in favor of NATS Jetstream. NATS is simpler to run in-cluster than Kafka, and jetstream scales well. I hope that Keda will support it?
Use-Case
I hope to use in conjunction with fission
Anything else?
No response
The text was updated successfully, but these errors were encountered: