Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite scaler is returning the earliest datapoint of a query, not the latest. #2366

Closed
bpinske opened this issue Nov 29, 2021 · 2 comments · Fixed by #2365
Closed

Graphite scaler is returning the earliest datapoint of a query, not the latest. #2366

bpinske opened this issue Nov 29, 2021 · 2 comments · Fixed by #2365
Labels
bug Something isn't working

Comments

@bpinske
Copy link
Contributor

bpinske commented Nov 29, 2021

Report

No response

Expected Behavior

Graphite's scaler acts on the most recent data available from a given query.

Actual Behavior

The scaler will act on the most outdated value returned by a query for a given time range.

Steps to Reproduce the Problem

  1. Define a scaler definition with a QueryTime of 1 hour
  2. Observe scaling behaviours act on hour-old data.

Logs from KEDA operator

example

KEDA Version

2.5.0

Kubernetes Version

No response

Platform

No response

Scaler Details

No response

Anything else?

Here you can see the graphite server response returns values in order of oldest to latest. With the final element of the response array being the most up-to-date timestamp. Graphite's scaler should be acting on the final element of the response array, not the first.

No response

@zroubalik
Copy link
Member

@bpinske do you think, that there might be some usecase where keeping the current behavior (oldest) makes sense?

@bpinske
Copy link
Contributor Author

bpinske commented Nov 30, 2021

It seems very unlikely to me there is any legitimate use in allowing people to intentionally use out of date data.
Prometheus's scaler does not have any equivalent back-in-time functionality either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants