Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Event Hub scaler doesn't log anything if the blob container name is wrong #2363

Closed
jrehnen opened this issue Nov 29, 2021 · 5 comments · Fixed by #2717
Closed

Azure Event Hub scaler doesn't log anything if the blob container name is wrong #2363

jrehnen opened this issue Nov 29, 2021 · 5 comments · Fixed by #2717
Assignees
Labels
enhancement New feature or request scaler-azure-event-hubs stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@jrehnen
Copy link

jrehnen commented Nov 29, 2021

While querying the scaling metric, if the scaler for Azure Event Hub cannot find the blob storage container the error message never gets logged.
Instead, the total amount of events in the hub is used as the value for the metric, whether they have already been handled or not.

This is due to the codeblock starting from the line in this link:

checkpoint, err = azure.GetCheckpointFromBlobStorage(ctx, scaler.httpClient, scaler.metadata.eventHubInfo, partitionInfo.PartitionID)

Due to this it is currently incredibly difficult to locate an error caused by a wrong blob storage container name.

@JorTurFer
Copy link
Member

Hi @jrehnen
Nice catch!, improvements in troubleshooting are always welcomed.
Thanks for noticing it ❤️
are you willing to contribute?

@tomkerkhove
Copy link
Member

I'm getting somebody to fix this, assigning to myself for now

@tomkerkhove tomkerkhove self-assigned this Dec 2, 2021
@stale
Copy link

stale bot commented Jan 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 31, 2022
@tomkerkhove tomkerkhove added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Jan 31, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jan 31, 2022
@sushmithavangala
Copy link
Contributor

We are looking at this issue

@tomkerkhove
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scaler-azure-event-hubs stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Archived in project
4 participants