Provide information concerning HashiCorp Vault in CRD

[tomkerkhove]

Proposal

Provide information concerning HashiCorp Vault in CRD since it's not surfaced yet when doing k get triggerauthentication.

Use-Case

No response

Anything else?

This would be more consistent since other stores are shown.

[Shubham82]

Hi @tomkerkhove
Just for confirmation in this, you want that when we run k get triggerauthentication then it would show HashiCorp Vault information also. if yes then in HashiCorp Vault there are the following fields:

address
authentication
role
mount
credential
   token
   serviceAccount

which fields you want to show them in the kubectl get ta command.

[tomkerkhove]

I'd keep it simple for now and just show the address, what do you think?

[Shubham82]

yha, I am also thinking of the address field as it is more suited than other fields.

[Shubham82]

Hi @tomkerkhove @zroubalik

Please suggest the name from the following for the HashiCorp Vault field which shows on running kubectl get ta

1) HashiCorpVault-ADDRESS
2) HashiCorpVault-Address
3) HashiCorp-Address
4) HashiCorp-ADDRESS
5) HASHICORP-ADDRESS

Any other name you want to add other than this.

[zroubalik]

HCVaultAddress or VaultAddress or? I keep it on @tomkerkhove and his preference.

[tomkerkhove]

Let's go with VaultAddress

[Shubham82]

Thanks, @tomkerkhove @zroubalik
VaultAddress seems good.

[Shubham82]

fixed for both ta and cta here #1862