Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple subscription names in Azure Service Bus scaler #1624

Closed
tomkerkhove opened this issue Feb 18, 2021 · 4 comments · Fixed by #3607
Closed

Support multiple subscription names in Azure Service Bus scaler #1624

tomkerkhove opened this issue Feb 18, 2021 · 4 comments · Fixed by #3607
Assignees
@raorugan
Labels
feature All issues for new features that have been committed to feature-request All issues for new features that have not been committed to Hacktoberfest help wanted Looking for support from community needs-discussion scaler-azure-service-bus

Comments

@tomkerkhove
Copy link
Member

Proposal

Support wildcard for subscription name in Azure Service Bus scaler so that KEDA will take an aggregate of all subscriptions on the topic.

Optional suggestion by Ahmed was to provide a list of subscriptions instead, which might also be a good option, but I would use a list then.

Use-Case

#1614
@tomkerkhove tomkerkhove added needs-discussion feature-request All issues for new features that have not been committed to scaler-azure-service-bus labels Feb 18, 2021
@ahmelsayed ahmelsayed self-assigned this Feb 19, 2021
@id27182
Copy link

id27182 commented Feb 22, 2021

Hi, @ahmelsayed! Do you plan to work on this during next month ? If no - I'd like to try to implement it

@tomkerkhove
Copy link
Member Author

That would be awesome! We are always happy to welcome contributions!

@tomkerkhove tomkerkhove assigned id27182 and unassigned ahmelsayed Feb 22, 2021
@ahmelsayed
Copy link
Contributor

Just echoing what @tomkerkhove said 👍

@tomkerkhove tomkerkhove added help wanted Looking for support from community Hacktoberfest labels Sep 28, 2021
@stale
Copy link

stale bot commented Nov 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Nov 27, 2021
@tomkerkhove tomkerkhove added the feature All issues for new features that have been committed to label Nov 29, 2021
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Nov 29, 2021
@tomkerkhove tomkerkhove assigned raorugan and unassigned id27182 May 11, 2022
This was referenced Aug 28, 2022
Merged
Merged
@JorTurFer JorTurFer mentioned this issue Oct 31, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raorugan raorugan

Labels
feature All issues for new features that have been committed to feature-request All issues for new features that have not been committed to Hacktoberfest help wanted Looking for support from community needs-discussion scaler-azure-service-bus
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support regex usage in Azure Service Bus scaler. v-shenoy/keda
4 participants
@ahmelsayed @tomkerkhove @id27182 @raorugan