-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for authentication (Bearer, Basic Auth and TLS) to the Prometheus scaler #1559
Comments
Seems like a valid usecase, are you willing to contribute this? |
This is (auth) something we are looking for as well, came here to create an issue, found this. |
@zroubalik yes, I can add that. @surki Are planning to add token auth as well or just basic auth? |
Just please try to follow other scalers and how are they dealing with authentication. So we have consistent user experience. Thx! |
@marpio OT: I'd be interested to know more about your usage of KEDA on OpenShift? Could you please contact me on kubernetes slack or on email? Thanks! |
@marpio I am looking at just basic auth. If you are planning to add both, I could wait. thanks. |
@surki yes, I'm planning to do both. I need this feature soon and will start implementing it tomorrow so it shouldn't take long. |
@zroubalik This was merged/closed almost 2 months ago, are you guys planning on doing a release? Really need this on Openshift to use the Prometheus scaler, would be much appreciated! |
@adrianchifor we are going to do the 2.3 release next week at the latest :) if you have any further questions, feel free to ping me on slack. |
Add support for authentication (Bearer, Basic Auth and TLS) to the Prometheus scaler.
Use-Case
I would like to use KEDA in a OpenShift 4 cluster and scale workloads using the Prometheus scaler. OpenShift's monitoring stack includes Prometheus which is accessible via Thanos Querier, which in turn has a oauth-proxy in front of it.
This means that the scaler would need to be able to pass OAuth Token in order to execute a query.
Tell us more what you'd like to achieve
Additionally the recent releases of Prometheus support Basic and TLS auth so this would be a nice addition too.
Specification
The text was updated successfully, but these errors were encountered: