Fix changelog order. Attend semgrep findings

Signed-off-by: Ruben Herrebrugh <raherrebrugh@gmail.com>
kedacore · Oct 30, 2024 · 7db6b2f · 7db6b2f
1 parent bf9684f
commit 7db6b2f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -58,12 +58,12 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
 ### New
 
 - **General**: Cache miss fallback in validating webhook for ScaledObjects with direct kubernetes client ([#5973](https://github.com/kedacore/keda/issues/5973))
+- **Azure Pipelines Scalar**: Print warning to log when Azure DevOps API Rate Limits are (nearly) reached ([#6284](https://github.com/kedacore/keda/issues/6284))
 - **CloudEventSource**: Introduce ClusterCloudEventSource ([#3533](https://github.com/kedacore/keda/issues/3533))
 - **CloudEventSource**: Provide ClusterCloudEventSource around the management of ScaledJobs resources ([#3523](https://github.com/kedacore/keda/issues/3523))
 - **CloudEventSource**: Provide ClusterCloudEventSource around the management of TriggerAuthentication/ClusterTriggerAuthentication resources ([#3524](https://github.com/kedacore/keda/issues/3524))
 - **Github Action**: Fix panic when env for runnerScopeFromEnv or ownerFromEnv is empty ([#6156](https://github.com/kedacore/keda/issues/6156))
 - **RabbitMQ Scaler**: provide separate paremeters for user and password ([#2513](https://github.com/kedacore/keda/issues/2513))
-- **Azure Pipelines Scalar**: Print warning to log when Azure DevOps API Rate Limits are (nearly) reached ([#6284](https://github.com/kedacore/keda/issues/6284))
 
 #### Experimental
 

diff --git a/pkg/scalers/azure_pipelines_scaler_test.go b/pkg/scalers/azure_pipelines_scaler_test.go
@@ -224,7 +224,11 @@ func TestAzurePipelinesMatchedAgent(t *testing.T) {
 
 func TestAzurePipelinesDelayed(t *testing.T) {
 	var apiStub = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		w.Header().Add("X-RateLimit-Limit", "0")
+
+		// nosemgrep: no-direct-write-to-responsewriter
+		w.Header().Add("X-RateLimit-Limit", "0") 
+
+		// nosemgrep: no-direct-write-to-responsewriter
 		w.Header().Add("X-RateLimit-Delay", "42")
 		w.WriteHeader(http.StatusOK)
 		_, _ = w.Write(buildLoadJSON())
@@ -237,7 +241,7 @@ func TestAzurePipelinesDelayed(t *testing.T) {
 		httpClient: http.DefaultClient,
 	}
 
-	queueLen, err := mockAzurePipelinesScaler.GetAzurePipelinesQueueLength(context.TODO())
+	queueLen, err := mockAzurePipelinesScaler.GetAzurePipelinesQueueLength(context.Background())
 
 	if err != nil {
 		t.Fail()