Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User configures prometheus.metricServer.serviceMonitor.port value will never be applied #647

Open
zyue110026 opened this issue Jun 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@zyue110026
Copy link
Contributor

User configures prometheus.metricServer.serviceMonitor.port value will never be applied.
Based on the documentation,

| `prometheus.metricServer.serviceMonitor.port` | string | `"metrics"` | Name of the service port this endpoint refers to. Mutually exclusive with targetPort |
, this variable is used to set endpoint’s name of service monitor, but due to incorrect value reference in
- port: {{ .Values.prometheus.metricServer.portName }}
, it references .Values.prometheus.metricServer.portName which is used for set port name of metric server.

Expected Behavior

User configures prometheus.metricServer.serviceMonitor.port value can be applied

Actual Behavior

User configures prometheus.metricServer.serviceMonitor.port value will never be applied

Steps to Reproduce the Problem

  1. install main version of charts through helm chart
  2. reconfigure prometheus.metricServer.serviceMonitor.port in value.yaml
  3. observe that new value not applied

Specifications

Recommend fix:

  endpoints:
 -  - port: {{ .Values.prometheus.metricServer.portName }}
 +  - port: {{ .Values.prometheus.metricServer.serviceMonitor.port }}
     {{- with .Values.prometheus.metricServer.serviceMonitor.targetPort }}
     targetPort: {{ . }}
     {{- end }}
 ```
@zyue110026 zyue110026 added the bug Something isn't working label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant