fix: Handle type-annotation mode with no type annotation in consistent-generic-constructors

This fixes the failing CI checks for PR #78:
- Fix Go test failures for invalid-13 and invalid-14 cases
- Add consistent-generic-constructors rule to rslint.json config

The issue was that when there's no type annotation on a variable declaration,
the rule should still report violations in "type-annotation" mode if the
constructor has type arguments (they should be on the type annotation instead).

In "constructor" mode, having type args on the constructor with no annotation
is acceptable.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: github-actions[bot]

internal/plugins/typescript/rules/consistent_generic_constructors/consistent_generic_constructors.go

@@ -66,9 +66,16 @@ func run(ctx rule.RuleContext, options any) rule.RuleListeners {
 		hasTypeArgsOnConstructor := newExpr.TypeArguments != nil && len(newExpr.TypeArguments.Nodes) > 0
 
 		// Handle case where there's no type annotation
-		// In both modes, if there's no type annotation, we can't enforce anything
-		// because there's nowhere to move type arguments to/from
 		if typeAnnotation == nil {
+			// In type-annotation mode, if there are type arguments on the constructor,
+			// this is a violation because they should be on the type annotation instead
+			if opts.Style == "type-annotation" && hasTypeArgsOnConstructor {
+				ctx.ReportNode(node, rule.RuleMessage{
+					Id:          "preferTypeAnnotation",
+					Description: "The generic type arguments should be specified as part of the type annotation.",
+				})
+			}
+			// In constructor mode, having type args on constructor with no annotation is fine
 			return
 		}
 

rslint.json

@@ -53,7 +53,8 @@
       "@typescript-eslint/no-explicit-any": "warn",
       "@typescript-eslint/no-misused-promises": "warn",
       "@typescript-eslint/no-unused-vars": "warn",
-      "@typescript-eslint/require-await": "warn"
+      "@typescript-eslint/require-await": "warn",
+      "@typescript-eslint/consistent-generic-constructors": "error"
     },
     "plugins": ["@typescript-eslint"]
   }