Skip to content

Commit 384a53c

Browse files
authored
Merge pull request #3493 from embik/remove-printing-column-apiexport
Remove additional printing column 'Ready' from APIExport
2 parents 3f9ad25 + 33855ba commit 384a53c

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

config/crds/apis.kcp.io_apiexports.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -292,9 +292,6 @@ spec:
292292
- jsonPath: .metadata.creationTimestamp
293293
name: Age
294294
type: date
295-
- jsonPath: .status.conditions[?(@.type=="VirtualWorkspaceURLsReady")].status
296-
name: Ready
297-
type: string
298295
name: v1alpha2
299296
schema:
300297
openAPIV3Schema:
@@ -550,8 +547,11 @@ spec:
550547
virtualWorkspaces:
551548
description: |-
552549
virtualWorkspaces contains all APIExport virtual workspace URLs.
550+
this field is empty unless kcp has been started with the
551+
'EnableDeprecatedAPIExportVirtualWorkspacesUrls' feature gate.
553552
554-
Deprecated: use APIExportEndpointSlice.status.endpoints instead
553+
Deprecated: use APIExportEndpointSlice.status.endpoints instead. This
554+
field will be removed in an upcoming API version.
555555
items:
556556
properties:
557557
url:

pkg/openapi/zz_generated.openapi.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/apis/apis/v1alpha2/types_apiexport.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ const (
5656
// +kubebuilder:subresource:status
5757
// +kubebuilder:resource:scope=Cluster,categories=kcp
5858
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
59-
// +kubebuilder:printcolumn:name="Ready",type="string",JSONPath=`.status.conditions[?(@.type=="VirtualWorkspaceURLsReady")].status`
6059
type APIExport struct {
6160
metav1.TypeMeta `json:",inline"`
6261
// +optional
@@ -323,8 +322,11 @@ type APIExportStatus struct {
323322
Conditions conditionsv1alpha1.Conditions `json:"conditions,omitempty"`
324323

325324
// virtualWorkspaces contains all APIExport virtual workspace URLs.
325+
// this field is empty unless kcp has been started with the
326+
// 'EnableDeprecatedAPIExportVirtualWorkspacesUrls' feature gate.
326327
//
327-
// Deprecated: use APIExportEndpointSlice.status.endpoints instead
328+
// Deprecated: use APIExportEndpointSlice.status.endpoints instead. This
329+
// field will be removed in an upcoming API version.
328330
//
329331
// +optional
330332
VirtualWorkspaces []VirtualWorkspace `json:"virtualWorkspaces,omitempty"`

0 commit comments

Comments
 (0)