Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front-proxy Ingress: add ingressClassName field #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ErwanDL
Copy link
Contributor

@ErwanDL ErwanDL commented Sep 13, 2024

The kubernetes.io/ingress.class annotation is deprecated since Kubernetes v1.18 (https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#deprecating-the-ingress-class-annotation).

This allows specifying an ingress class via the spec.ingressClassName field of the Ingress resource, and exposes a corresponding kcpFrontProxy.ingress.ingressClassName key in values.yaml.

Note: this should still be fully backwards-compatible. Users that for any reason still want to use the kubernetes.io/ingress.class annotation can always leave ingressClassName empty and rely on kcpFrontProxy.ingress.annotations just like before.

The kubernetes.io/ingress.class annotation is deprecated since Kubernetes
v1.18 (https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#deprecating-the-ingress-class-annotation).

This allows specifying an ingress class via the spec.ingressClassName
field of the Ingress resource, and exposes a corresponding
kcpFrontProxy.ingress.ingressClassName key in values.yaml.

Signed-off-by: Erwan DE LEPINAU <elepinau@evroc.com>
@kcp-ci-bot kcp-ci-bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Sep 13, 2024
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign scheeles for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 13, 2024
@kcp-ci-bot
Copy link
Contributor

Hi @ErwanDL. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2024
@sttts
Copy link
Member

sttts commented Sep 18, 2024

/ok-to-test

Sgtm

@mjudeikis looks good?

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants