Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance lsp hover #621

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat: enhance lsp hover #621

merged 1 commit into from
Aug 2, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 25, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

feat: enhance lsp hover. Hover for schema varibale display schema pkg, schema name, doc and attrs

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy added the lsp label Jul 25, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Jul 25, 2023
@He1pa He1pa force-pushed the enhance_lsp_hover branch 2 times, most recently from d2dd2be to ca7c908 Compare July 26, 2023 03:33
@He1pa He1pa marked this pull request as ready for review August 2, 2023 03:48
@coveralls
Copy link
Collaborator

coveralls commented Aug 2, 2023

Pull Request Test Coverage Report for Build 5734494378

  • 83 of 97 (85.57%) changed or added relevant lines in 3 files are covered.
  • 26 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-19.2%) to 68.823%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/hover.rs 22 23 95.65%
kclvm/sema/src/resolver/doc.rs 0 2 0.0%
kclvm/tools/src/LSP/src/tests.rs 61 72 84.72%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 26 58.06%
Totals Coverage Status
Change from base Build 5714578495: -19.2%
Covered Lines: 31938
Relevant Lines: 46406

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kclvm/tools/src/LSP/src/hover.rs Show resolved Hide resolved
@Peefy Peefy merged commit c88eadf into kcl-lang:main Aug 2, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants