KCL lambda arguments type checking in the language server

[dennybaa]

Hello, there

it looks like an odd behavior:

schema ProviderFamily:
    version: str
    providers: [str]
    marketplace: bool = True

providerFamily = lambda family: base.ProviderFamily {
    family
}
v = crossplane.providerFamily({
    version: "1.6.0"
    providers: [
        "provider-gcp-storage"
        "provider-gcp-compute"
    ]
    hello: "world"
})

I expect that the language server will be more informative regarding "hello", though it's not noticed, even CLI run provides meaningless error:

 kcl run appsops/iaas/crossplane/
EvaluationError
--> /home/dennybaa/code/play/pkg/apps/crossplane/base.k:1:1

Related scenario (which works, but should not)

schema Nested:
    m1?: str
    m2?: str

schema Top:
    inner: Nested

lambda a: Top {
}({
    inner: {hello: "world"}
})

4. What is your KCL components version? (Required)

0.9.4

[Peefy]

@He1pa

Could you help fix it?

[dennybaa]

Also it seems broader than this @Peefy , what do you think of an idea if arguments are passed to functions their copies are are constructed using the actual argument type? Does this sound sane or maybe nonsense?

[dennybaa]

I guess impossible due to union TA | TB types...

[Peefy]

No worries, I will refactor this and fix this issue.

[dennybaa]

Hello there @Peefy, I'd like add more details, as I face runtime type checking failures, so it seems crucial.

Let's suppose we have a mutate function:

## vmgroups list
mutateGroups = lambda mutation: any, groups: [vm.OperatorVictoriametricsComV1beta1VMRuleSpecGroupsItems0] {
    [group | mutation for group in groups]
}

I define a vmrule:

vm.VMRule {
    metadata: base.metadata | {
        #name = config.app_id(item.resource_name())
        name = "xxxx"
        labels: {"team" = config.team, "app.kubernetes.io/name" = "rules"}
    }
  
    spec.groups: base.mutateGroups({labels.team = config.team}, [{
        name = "cert-manager"
        rules = [
            {
                alert = "cert-manager certificate expires soon"
                expr = "certmanager_certificate_expiration_timestamp_seconds - time() < 10 * 86400"
                $for = '5m'
                labels = {
                    severity = "critical"
                    service = "infra"
                }
                annotations = {
                    summary = "{{ $labels.cluster_name }}/{{ $labels.name }} expires in 10 days"
                }
            }
        ]
    }])
}

And get the runtime failure:

68 |         spec.groups: base.mutateGroups({labels.team = config.team}, [{
   |                                                ^ Cannot add member 'team' to schema 'OperatorVictoriametricsComV1beta1VMRuleSpecGroupsItems0'

However, I just need to move the groups assignment out and runtime is operational. In other words:

groups = base.mutateGroups(...)
vm.VMRule {
    metadata: base.metadata | {
        #name = config.app_id(item.resource_name())
        name = "xxxx"
        labels: {"team" = config.team, "app.kubernetes.io/name" = "rules"}
    }
    spec.groups: groups
}

This looks like kinda important error to me, smth is wrong with the type checking system and runtime.

[Peefy]

Yes, I've fixed the type unsoundness at compile time and runtime through these PRs

• feat: enhance runtime type cast and check for lambda arguments and return values #1529
• refactor: dict upgrade schema type and check #1531
• ...

[dennybaa]

Great, let's see then. Though unreleased yet?

[Peefy]

Yes, I expect to release v0.10.0-alpha version.

[Peefy]

Closed by #1531 and #1529, released in KCL v0.10.0-beta.1