Skip to content

Commit f90fa55

Browse files
committed
[lldb][gui] use just '#2' instead of 'frame #2' in the threads/frame view
Since the threads/frame view is taking only a small part on the right side of the screen, only a part of the function name of each frame is visible. It seems rather wasteful to spell out 'frame' there when it's obvious that it is a frame, it's better to use the space for more of the function name. Differential Revision: https://reviews.llvm.org/D122998
1 parent aaca2ac commit f90fa55

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

lldb/source/Core/IOHandlerCursesGUI.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5016,8 +5016,7 @@ class FrameTreeDelegate : public TreeDelegate {
50165016
public:
50175017
FrameTreeDelegate() : TreeDelegate() {
50185018
FormatEntity::Parse(
5019-
"frame #${frame.index}: {${function.name}${function.pc-offset}}}",
5020-
m_format);
5019+
"#${frame.index}: {${function.name}${function.pc-offset}}}", m_format);
50215020
}
50225021

50235022
~FrameTreeDelegate() override = default;

lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def test_gui(self):
3333
self.child.expect_exact("Threads")
3434

3535
# The thread running thread_start_routine should be expanded.
36-
self.child.expect_exact("frame #0: break_here")
36+
self.child.expect_exact("#0: break_here")
3737

3838
# Exit GUI.
3939
self.child.send(escape_key)
@@ -47,7 +47,7 @@ def test_gui(self):
4747
self.child.expect_exact("Threads")
4848

4949
# The main thread should be expanded.
50-
self.child.expect("frame #\d+: main")
50+
self.child.expect("#\d+: main")
5151

5252
# Quit the GUI
5353
self.child.send(escape_key)

0 commit comments

Comments
 (0)