Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier #23

Open
curran opened this issue Nov 29, 2021 · 1 comment
Open

Prettier #23

curran opened this issue Nov 29, 2021 · 1 comment

Comments

@curran
Copy link
Collaborator

curran commented Nov 29, 2021

When working with this codebase, there are different formatting conventions in different files (e.g. tabs in tests.js and spaces in index.test.js. Having worked with Prettier in most of my projects, I can advocate for its use as a time saving tool. It formats the code automatically so that we as authors never need to think about formatting. I would suggest that we adopt Prettier in this codebase, as it will make work going forward easier.

@kbadk
Copy link
Owner

kbadk commented Nov 29, 2021

I'll admit I prefer the feature set of ESLint over Prettier, but either one would be an improvement, so I'll leave the decision up to the implementer. I'd also prefer an implementation that has the least impact on functional code (i.e. index.js). ESLint allows you to tailor the ruleset more than Prettier to my knowledge, but I'll be happy with either solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants