v0.8.1 fix tree modify method

Author: kayjan

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.8.1] - 2023-03-10
+### Fixed
+- Tree Modify: Fix issue of `sep` of tree differing from the `sep` in `from_paths` and `to_paths`.
+
 ## [0.8.0] - 2023-03-10
 ### Added
 - Type Checking: Type checking with `mypy`, added type checks to pre-commit hooks.
@@ -213,6 +217,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Utility Iterator: Tree traversal methods.
 - Workflow To Do App: Tree use case with to-do list implementation.
 
+[0.8.1]: https://github.com/kayjan/bigtree/compare/v0.8.0...v0.8.1
 [0.8.0]: https://github.com/kayjan/bigtree/compare/v0.7.4...v0.8.0
 [0.7.4]: https://github.com/kayjan/bigtree/compare/v0.7.3...v0.7.4
 [0.7.3]: https://github.com/kayjan/bigtree/compare/v0.7.2...v0.7.3

bigtree/__init__.py

@@ -1,4 +1,4 @@
-__version__ = "0.8.0"
+__version__ = "0.8.1"
 
 from bigtree.binarytree.construct import list_to_binarytree
 from bigtree.dag.construct import dataframe_to_dag, dict_to_dag, list_to_dag

bigtree/tree/modify.py

@@ -816,7 +816,7 @@ def copy_or_shift_logic(
                     # Create intermediate parent node, if applicable
                     while (not to_node) & (idx + 1 < len(to_path_list)):
                         idx += 1
-                        to_path_parent = sep.join(to_path_list[:-idx])
+                        to_path_parent = tree_sep.join(to_path_list[:-idx])
                         if transfer_indicator:
                             to_node = find_path(to_tree, to_path_parent)  # type: ignore
                         else:

tests/tree/test_modify.py

@@ -156,6 +156,7 @@ def test_copy_nodes_create_intermediate_path(self):
         copy_nodes(self.root, from_paths, to_paths)
         assert self.root.max_depth == 4, "Shift did not create a tree of depth 4"
 
+    # sep
     def test_copy_nodes_sep_undefined(self):
         from_paths = ["\\d", "\\e", "\\g", "\\h", "\\f"]
         to_paths = ["a\\b\\d", "a\\b\\e", "a\\b\\e\\g", "a\\b\\e\\h", "a\\c\\f"]
@@ -177,6 +178,25 @@ def test_copy_nodes_sep(self):
         assert_tree_structure_basenode_root_attr(self.root)
         assert_tree_structure_node_root_generic(self.root)
 
+    def test_copy_nodes_sep_different(self):
+        # Delete intermediate nodes
+        from_paths = ["\\a\\b", "\\a\\c", "\\a\\e"]
+        to_paths = [None, None, None]
+        shift_nodes(self.root, from_paths, to_paths, sep="\\")
+
+        # Create intermediate nodes
+        from_paths = ["\\d", "\\g", "\\h", "\\f"]
+        to_paths = ["a\\b\\d", "a\\b\\e\\g", "a\\b\\e\\h", "a\\c\\f"]
+        copy_nodes(self.root, from_paths, to_paths, sep="\\")
+
+        # Delete original nodes
+        from_paths = ["\\a\\d", "\\a\\g", "\\a\\h", "\\a\\f"]
+        to_paths = [None, None, None, None]
+        shift_nodes(self.root, from_paths, to_paths, sep="\\")
+
+        assert_tree_structure_basenode_root_generic(self.root)
+        assert_tree_structure_node_root_generic(self.root)
+
     # skippable
     def test_copy_nodes_skippable(self):
         from_paths = ["i", "d", "e", "g", "h", "f"]