Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing fails on windows i386 #17

Closed
myoung3 opened this issue Jun 29, 2020 · 1 comment
Closed

testing fails on windows i386 #17

myoung3 opened this issue Jun 29, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@myoung3
Copy link
Member

myoung3 commented Jun 29, 2020 •
edited
Loading

Likely traced to a bug in data.table::foverlaps reported here
Rdatatable/data.table#4580

I could switch all the code to equivalent non-equijoins but previous timings I've done suggest that foverlaps is faster than an equivalent non-equijoin. Plus, the non-equijoin doesn't retain both sets of the interval join columns so extra work would need to be done around column naming to reproduce the exact functionality of foverlaps. It's probably better to leave the code as is and wait for a fix in data.table since all intervalaverage checks are passing on windows 64 bit and linux.
@myoung3 myoung3 added the bug Something isn't working label Jun 29, 2020
@myoung3
Copy link
Member Author

myoung3 commented Jul 17, 2020

partly fixed in #23
completely fixed in af42e34 (no pull request for this since I accidentally pushed to main)

@myoung3 myoung3 closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@myoung3