unit tests

- add more unit tests
- apply fixes to source per unit tests
- now 100% coverage

Author: ackspony

coverage.txt

@@ -1,33 +1,41 @@
 
 
-Code Coverage Report:      
-  2018-11-30 01:39:31      
-                           
- Summary:                  
-  Classes: 66.67% (12/18)  
-  Methods: 72.09% (31/43)  
-  Lines:   54.21% (116/214)
+Code Coverage Report:       
+  2018-12-06 00:19:24       
+                            
+ Summary:                   
+  Classes: 100.00% (18/18)  
+  Methods: 100.00% (43/43)  
+  Lines:   100.00% (186/186)
 
 \Webhook::PopulatorTrait
   Methods: 100.00% ( 1/ 1)   Lines: 100.00% ( 11/ 11)
+\Webhook::Webhook\Callback
+  Methods: 100.00% ( 3/ 3)   Lines: 100.00% ( 43/ 43)
+\Webhook::Webhook\CallbackRule
+  Methods: 100.00% ( 2/ 2)   Lines: 100.00% (  6/  6)
+\Webhook::Webhook\EventCallbackRule
+  Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  2/  2)
 \Webhook::Webhook\EventMissingException
   Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  2/  2)
 \Webhook::Webhook\InvalidRequestException
-  Methods:  50.00% ( 1/ 2)   Lines:  75.00% (  3/  4)
+  Methods: 100.00% ( 2/ 2)   Lines: 100.00% (  4/  4)
 \Webhook::Webhook\MessageBodyInvalidException
   Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  2/  2)
 \Webhook::Webhook\Payload
   Methods: 100.00% ( 2/ 2)   Lines: 100.00% (  5/  5)
 \Webhook::Webhook\Request
-  Methods:  66.67% ( 8/12)   Lines:  66.67% ( 34/ 51)
+  Methods: 100.00% (12/12)   Lines: 100.00% ( 51/ 51)
 \Webhook::Webhook\SignatureInvalidException
   Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  2/  2)
 \Webhook::Webhook\SignatureMissingException
   Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  2/  2)
+\Webhook::Webhook\UrlCallbackRule
+  Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  2/  2)
 \Webhook\Payload::Webhook\Payload\Event
-  Methods: 100.00% ( 4/ 4)   Lines: 100.00% ( 11/ 11)
+  Methods: 100.00% ( 5/ 5)   Lines: 100.00% ( 11/ 11)
 \Webhook\Payload::Webhook\Payload\PingEvent
-  Methods: 100.00% ( 4/ 4)   Lines: 100.00% ( 11/ 11)
+  Methods: 100.00% ( 3/ 3)   Lines: 100.00% ( 10/ 10)
 \Webhook\Payload::Webhook\Payload\PushEvent
   Methods: 100.00% ( 4/ 4)   Lines: 100.00% ( 18/ 18)
 \Webhook\PayloadData::CommitTrait

src/Callback.php

@@ -118,7 +118,9 @@ public function validatePayload(Payload $payload)  {
    public function __construct(string $hubSecret,callable $callback,CallbackRule ...$CallbackRule) {
       $this->_hubSecret = $hubSecret;
       $this->_callback = $callback;
+      
       foreach($CallbackRule as $v) {
+         
          if ($v instanceof UrlCallbackRule) {
             $this->_urlRule []= (string) $v;
          }

src/Payload.php

@@ -2,6 +2,7 @@
 namespace Webhook;
 
 use Webhook\PayloadData\Sender;
+use Webhook\PayloadData\Repository;
 
 abstract class Payload implements Populatable, PopulateListener {
 
@@ -15,6 +16,7 @@ abstract public function getEvent():string;
     * @var \Webhook\PayloadData\Sender
     */
    public $sender;
+
 
    use PopulatorTrait;
 

src/Payload/Event.php

@@ -2,8 +2,12 @@
 namespace Webhook\Payload;
 
 use Webhook\Payload;
-
+use Webhook\PayloadData\Repository;
 class Event extends Payload implements EventProviderInterface {
+   /**
+    * @var \Webhook\PayloadData\Repository
+    */
+   public $repository;
 
    /**
     * Populates a "generic" Payload <b>Event</b> object corresponding to this event.
@@ -50,19 +54,24 @@ public function __construct($input,string $gitHubEvent) {
 
       $this->_event = $gitHubEvent;
 
-      $pubProp = [];
-      foreach((new \ReflectionObject($input))->getProperties(\ReflectionProperty::IS_PUBLIC) as $v) {
-         $pubProp[]=$v->getName();
-      }
-      unset($v);
+//       $pubProp = [];
+//       foreach((new \ReflectionObject($input))->getProperties(\ReflectionProperty::IS_PUBLIC) as $v) {
+//          $pubProp[]=$v->getName();
+//       }
+//       unset($v);
 
       $this->_payloadData = json_decode(json_encode($input),true);
 
 
    }
 
 
-   
+   public function populateComplete() {
+      parent::populateComplete();
+      if (!$this->repository instanceof Repository) {
+         $this->repository = (new Repository)->populateFromObject($this->repository);
+      }
+   }
 
 
 

src/Payload/PingEvent.php

@@ -5,7 +5,7 @@
 use Webhook\PayloadData\Hook;
 use Webhook\PayloadData\PingRepository;
 
-class PingEvent extends Payload implements EventProviderInterface {
+class PingEvent extends Payload  {
 
    /**
     * @var string The random message generated for this ping event.
@@ -35,13 +35,15 @@ class PingEvent extends Payload implements EventProviderInterface {
 
    const EVENT_NAME = 'ping';
 
-   /**
-    * Populates a "generic" Payload <b>Event</b> object corresponding to this event.
-    * @return \Webhook\Payload\Event
-    */
-   public function toEvent() : Event {
-      return new Event($this->input,static::EVENT_NAME);
-   }
+//    /**
+//     * Populates a "generic" Payload <b>Event</b> object corresponding to this event.
+//     * @return \Webhook\Payload\Event
+//     */
+//    public function toEvent() : Event {
+//       $data = json_decode(json_encode($this));
+      
+//       return new Event(json_decode(json_encode($this)),static::EVENT_NAME);
+//    }
 
    /**
     * Provides the event name.