Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lmtp_sdr() call to v1.4.0 ? #1

Open
swihart opened this issue Sep 19, 2024 · 0 comments
Open

Update lmtp_sdr() call to v1.4.0 ? #1

swihart opened this issue Sep 19, 2024 · 0 comments

Comments

@swihart
Copy link

swihart commented Sep 19, 2024

Thanks for the repo and the Epidemiology paper! Should the following chunk in run_lmtp.R be updated with lmtp_control()?

That is, update

progressr::with_progress(
  out_null <-
    lmtp_sdr(
      dat,
      trt = a[seq_len(this_time)],
      outcome = y[seq_len(this_time)],
      baseline = bs,
      time_vary = tv[seq_len(this_time)],
      cens = censoring[seq_len(this_time)],
      outcome_type = ifelse(this_time == 1, "binomial", "survival"),
      #learners_outcome = lrnrs,
      #learners_trt = lrnrs,
      folds = folds,
      .SL_folds = SL_folds,
      .trim = trim,
      k = k
      )
)

to

progressr::with_progress(
  out_null <-
    lmtp_sdr(
      dat,
      trt = a[seq_len(this_time)],
      outcome = y[seq_len(this_time)],
      baseline = bs,
      time_vary = tv[seq_len(this_time)],
      cens = censoring[seq_len(this_time)],
      outcome_type = ifelse(this_time == 1, "binomial", "survival"),
      #learners_outcome = lrnrs,
      #learners_trt = lrnrs,
      folds = folds,
      #.SL_folds = SL_folds,
      #.trim = trim,
      control=lmtp_control(.trim=trim, .learners_trt_folds=SL_folds, .learners_outcome_folds = SL_folds),
      k = k
      )
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant