This repository was archived by the owner on May 12, 2021. It is now read-only.
shimv2: fix the issue of stop container failed #1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifupan
force-pushed
the
fixstop
branch
2 times, most recently
from
04042bf to
ce1432d
Compare
Member
Author
|
/test |
|
dnm - waiting for kata-containers/agent#526 |
bergwolf
approved these changes
Apr 9, 2019
Member
Author
|
/test |
There is no need to send another SIGKILL signal following SIGTERM signal, otherwise, sending the SIGKILL signal would get failed since the container process would has been terminated by the previous SIGTERM signal. Fixes:kata-containers#1493 Signed-off-by: lifupan <lifupan@gmail.com>
Member
Author
|
/test |
devimc
approved these changes
Apr 11, 2019
Merged
ganeshmaharaj
pushed a commit
to ganeshmaharaj/kata-runtime
that referenced
this pull request
Apr 16, 2019
shimv2: fix the issue of stop container failed (cherry picked from commit c08976e) Fixes:kata-containers#1493 Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to send another SIGKILL signal following
SIGTERM signal, otherwise, sending the SIGKILL signal would
get failed since the container process would has been terminated
by the previous SIGTERM signal.
Fixes:#1493
Signed-off-by: lifupan lifupan@gmail.com