qemu: Move to qemu 2.11 #119
Conversation
|
lgtm |
| url: "https://github.com/kata-containers/qemu" | ||
| version: "741f430a960b5b67745670e8270db91aeb083c5f-29" | ||
| release: "19360" | ||
| version: "stable-2.11" |
There was a problem hiding this comment.
Why are we still relying on url: "https://github.com/kata-containers/qemu" ? I thought we could point to the official qemu repo since we want a vanilla version here.
There was a problem hiding this comment.
Just because in kata-containers/qemu we have the configure.sh script which provides the flags that we use.
https://github.com/kata-containers/qemu/blob/stable-2.11/configure.sh
There was a problem hiding this comment.
As mentioned kata-containers/tests#182 (comment) though, we shouldn't be storing the config script in the qemu branch itself.
So I think we can switch the URL here.
| url: "https://github.com/kata-containers/qemu" | ||
| version: "741f430a960b5b67745670e8270db91aeb083c5f-29" | ||
| release: "19360" | ||
| version: "stable-2.11" |
There was a problem hiding this comment.
As mentioned kata-containers/tests#182 (comment) though, we shouldn't be storing the config script in the qemu branch itself.
So I think we can switch the URL here.
| const ( | ||
| qemuArchBaseMachineType = "pc" | ||
| qemuArchBaseQemuPath = "/usr/bin/qemu-lite-system-x86_64" | ||
| qemuArchBaseQemuPath = "/usr/bin/qemu-system-x86_64" |
There was a problem hiding this comment.
If we are dropping qemu-lite entirely, there are changes we'll need to make in a few other areas (search for QemuPCLite).
There was a problem hiding this comment.
I think the default will be using the vanilla 2.11 QEMU, though we are expecting a pc-lite supporting qemu-lite to be available in the future as well. So, I think its reasonable to keep here for now? WDYT @jodh-intel
This commit modifies version.yaml to now point to the qemu 2.11 stable version. It modifies the default QEMU_CMD to be qemu-system-x86_64 instead of qemu-lite-system-x86_64. And modifies virtcontainers unit tests to now point to the correct QEMU_CMD. Fixes: kata-containers#118. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
|
CI should pass now that kata-containers/tests#182 has been merged. @jodh-intel PTAL |
|
CI passed correctly. ping @kata-containers/runtime |
|
@bergwolf PTAL |
|
@egernst PTAL |
|
lgtm
|
|
All looking good and green. I believe we have addressed @jodh-intel 's comments, but he will not be around for a few days to ack his requested changes - so pls don't let @jodh-intel 's review change request block this now. I see enough ack's - so, merging this now... |
Instead of using a custom version of qemu, we should use qemu version from upstream. Fixes clearcontainers#163. Depends-on: github.com/kata-containers/runtime#119 Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
Updated the build to support building for the ppc64le architecture. Fixes kata-containers#119 Signed-off-by: Basheer K <basheer@linux.vnet.ibm.com>
7 participants
This commit modifies version.yaml to now point to the qemu
2.11 stable version.
It modifies the default QEMU_CMD to be qemu-system-x86_64
instead of qemu-lite-system-x86_64.
And modifies virtcontainers unit tests to now point to the
correct QEMU_CMD.
Fixes: #118.
Depends-on: github.com/kata-containers/tests#182
Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com