Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey System #26

Open
2 tasks
TheUltDev opened this issue Jun 16, 2023 · 4 comments
Open
2 tasks

Hotkey System #26

TheUltDev opened this issue Jun 16, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@TheUltDev
Copy link
Contributor

  • Implement hotkey system (use Ninja Keys or similar)
  • Add common shortcuts to Watermark component
@TheUltDev TheUltDev added the enhancement New feature or request label Jun 16, 2023
@FossPrime
Copy link
Collaborator

FossPrime commented Jun 16, 2023

Can you Ctrl + C currently? Like after running npx serve ... its perma stuck for me... but my laptops frequently get assumed to be a Mac, as they are not Windows.

@TheUltDev
Copy link
Contributor Author

@FossPrime I cannot. It must have been a regression at some point, I used to be able to.

@TheUltDev
Copy link
Contributor Author

@FossPrime testing your latest PR I noticed Ctrl + C works.
Either you fixed it or it's an intermittent issue in the xterm or webcontainer libs.

@TheUltDev TheUltDev self-assigned this Jun 17, 2023
@FossPrime
Copy link
Collaborator

FossPrime commented Jun 17, 2023

@FossPrime testing your latest PR I noticed Ctrl + C works. Either you fixed it or it's an intermittent issue in the xterm or webcontainer libs.

Looks like something we did fixed it... i can still reproduce after deploying my secrets-api branch to https://vslite.42x.app

Screenshot_20230617-143020

For this purpose I also tried to setup a minimal repro repo... but its too minimal to allow repro of the Ctrl+C issue

https://wc.42x.app

I did notice while testing that before, I would often get two terminals in my dom, right next to each other. Perhaps sick kill was going to one but not the other. The first terminal was difficult to see and could not be interacted with. It only visibly appeared when resizing the terminal to a large height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants