Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch job does not terminate with Karma 1.4.0 #2552

Open
bennycode opened this issue Jan 27, 2017 · 2 comments
Open

Batch job does not terminate with Karma 1.4.0 #2552

bennycode opened this issue Jan 27, 2017 · 2 comments

Comments

@bennycode
Copy link

Expected behaviour

The batch job gulp test_browser should terminate when the Gulp task test_browser finishes.

Actual behaviour

The batch job gulp test_browser does not terminate when the Gulp task test_browser finishes. I need to kill the job manually (Ctrl + C).

Environment Details

  • Operating system: Windows 10 Home
  • Karma version (output of karma --version): 1.4.0

gulpfile.js

gulp.task('test_browser', function(done) {
  gutil.log(gutil.colors.yellow('Running tests in Google Chrome:'));

  var server = new Server({
    configFile: __dirname + '/karma.conf.js',
    files: [
      'test/js/helpers/**/*.js',
      paths.dist_window + '/**/*.js',
      'test/js/specs/**/*Spec.js'
    ]
  }, done);

  server.start();
});

Steps to reproduce the behaviour

  1. I upgraded from "karma": "1.3.0" to "karma": "1.4.0" (in package.json)
  2. When I run gulp test_browser, then this job does not terminate with Karma 1.4.0 (but it does with Karma 1.3.0)
  3. The project I used for testing is: https://github.com/wireapp/bazinga64

Terminal output with Karma v1.3.0 server

karma-1-3-0

Terminal output with Karma v1.4.0 server

karma-1-4-0

Please let me know if you need more details. Happy to help!

@dignifiedquire
Copy link
Member

Thank you for the report

@grifball
Copy link
Contributor

grifball commented Feb 9, 2017

I tried your repo on Ubuntu 16 (updated to karma 1.4 and ran 'gulp test_browser' in chrome) and it terminated correctly. Seems to be a windows thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants