From 294dda7de4b61626996630505d181d0dcfa7a367 Mon Sep 17 00:00:00 2001 From: rogeriopvl Date: Wed, 21 Nov 2018 00:26:43 +0000 Subject: [PATCH 1/4] refactor: swap out fs-access for core fs The fs-access module was a ponyfill for node 0.12 which is no longer maintained. --- index.js | 8 ++++---- package.json | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/index.js b/index.js index 4ecdf73..5e6ec54 100644 --- a/index.js +++ b/index.js @@ -1,4 +1,4 @@ -var fsAccess = require('fs-access') +var fs = require('fs') var path = require('path') var which = require('which') @@ -63,7 +63,7 @@ function getChromeExe (chromeDirName) { prefix = prefixes[i] try { windowsChromeDirectory = path.join(prefix, suffix) - fsAccess.sync(windowsChromeDirectory) + fs.accessSync(windowsChromeDirectory) return windowsChromeDirectory } catch (e) {} } @@ -112,7 +112,7 @@ function getChromiumExe (chromeDirName) { prefix = prefixes[i] try { windowsChromiumDirectory = path.join(prefix, suffix) - fsAccess.sync(windowsChromiumDirectory) + fs.accessSync(windowsChromiumDirectory) return windowsChromiumDirectory } catch (e) {} } @@ -144,7 +144,7 @@ function getChromeDarwin (defaultPath) { try { var homePath = path.join(process.env.HOME, defaultPath) - fsAccess.sync(homePath) + fs.accessSync(homePath) return homePath } catch (e) { return defaultPath diff --git a/package.json b/package.json index 7eb0645..7ec7cf9 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,6 @@ ], "author": "Vojta Jina ", "dependencies": { - "fs-access": "^1.0.0", "which": "^1.2.1" }, "license": "MIT", From 38db702f4561772490b15c14269c950951f14471 Mon Sep 17 00:00:00 2001 From: rogeriopvl Date: Wed, 21 Nov 2018 00:38:55 +0000 Subject: [PATCH 2/4] chore: bump mocha, chai and sinon to latest --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 7ec7cf9..06ae216 100644 --- a/package.json +++ b/package.json @@ -23,7 +23,7 @@ }, "license": "MIT", "devDependencies": { - "chai": "^3.3.0", + "chai": "^4.2.0", "grunt": "^1.0.1", "grunt-auto-release": "^0.0.7", "grunt-bump": "^0.8.0", @@ -36,8 +36,8 @@ "karma": "1.x || ^0.13.10", "karma-mocha": "1.x || ^0.2.0", "load-grunt-tasks": "^3.2.0", - "mocha": "^3.2.0", - "sinon": "^2.0.0", + "mocha": "^5.2.0", + "sinon": "^7.1.1", "standard": "^10.0.0" }, "contributors": [ From b33f1b4bebeb65d94e8c0638c7cb63a870b948b6 Mon Sep 17 00:00:00 2001 From: rogeriopvl Date: Wed, 21 Nov 2018 00:48:09 +0000 Subject: [PATCH 3/4] chore: bump standard to latest and fix lint --- package.json | 2 +- test/jsflags.spec.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 06ae216..87c27d0 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,7 @@ "load-grunt-tasks": "^3.2.0", "mocha": "^5.2.0", "sinon": "^7.1.1", - "standard": "^10.0.0" + "standard": "^12.0.0" }, "contributors": [ "Mark Ethan Trostler ", diff --git a/test/jsflags.spec.js b/test/jsflags.spec.js index 029211e..0998d51 100644 --- a/test/jsflags.spec.js +++ b/test/jsflags.spec.js @@ -46,7 +46,7 @@ describe('canaryGetOptions', function () { var parent = sinon.stub().returns(['-incognito']) var context = {} var url = 'http://localhost:9876' - var args = {flags: ['--js-flags="--expose-gc"']} + var args = { flags: ['--js-flags="--expose-gc"'] } expect(canaryGetOptions.call(context, url, args, parent)).to.be.eql([ '-incognito', '--js-flags=--expose-gc --nocrankshaft --noopt' From 1861a15976849d4fe7ccb8bbfc0ae1004ae9ca42 Mon Sep 17 00:00:00 2001 From: rogeriopvl Date: Wed, 21 Nov 2018 01:09:58 +0000 Subject: [PATCH 4/4] chore: update karma, grunt and related packages --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 87c27d0..8a2ad29 100644 --- a/package.json +++ b/package.json @@ -29,13 +29,13 @@ "grunt-bump": "^0.8.0", "grunt-conventional-changelog": "^6.1.0", "grunt-conventional-github-releaser": "^1.0.0", - "grunt-karma": "1.x || ^0.12.1", + "grunt-karma": "^3.0.0", "grunt-npm": "^0.0.2", "grunt-simple-mocha": "^0.4.0", "jasmine-node": "^1.14.5", - "karma": "1.x || ^0.13.10", + "karma": "^3.1.1", "karma-mocha": "1.x || ^0.2.0", - "load-grunt-tasks": "^3.2.0", + "load-grunt-tasks": "^4.0.0", "mocha": "^5.2.0", "sinon": "^7.1.1", "standard": "^12.0.0"