Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release grunt-karma 3.0 #261

Closed
johnjbarton opened this issue Aug 22, 2018 · 6 comments
Closed

Release grunt-karma 3.0 #261

johnjbarton opened this issue Aug 22, 2018 · 6 comments
Assignees
@johnjbarton

Comments

@johnjbarton
Copy link
Contributor

@Krinkle assign this to me when you are ready (the release scripts have some issues I am trying to iron).

IMO the package.json should dep karma ^3.0.0 since that is where the integration tests run.
@Krinkle
Copy link
Collaborator

Krinkle commented Aug 24, 2018

@johnjbarton Thanks, will do. By the way, which integration tests are you referring to?

@johnjbarton
Copy link
Contributor Author

https://github.com/karma-runner/karma/search?q=integration-tests.sh&unscoped_q=integration-tests.sh

@Krinkle
Copy link
Collaborator

Krinkle commented Aug 27, 2018

@johnjbarton Tthe integration tests don't currently cover grunt-karma (I think). Is your intention to make just make sure we are testing and passing with the latest version of Karma (devDeps), or were you referring the peerDeps support requirement?

One the projects I work on uses grunt-karma 2.0 with karma 2.x, and while it runs fine, it surprises me that it installs without warnings. I'd expect npm to warn about the specified version in package.json (karma@2.0.2) not satisfying grunt-karma's ^0.13.0 || ^1.0.0 peer dependency. But.. that maybe be a problem for another time.

Can we / should we continue to support the older versions, or add 3.x to the pipe?

Krinkle added a commit that referenced this issue Aug 27, 2018
@Krinkle
fix(deps): Update test to use karma 3.0.0
19551fd 
Ref #261.
Closes #251.
@johnjbarton
Copy link
Contributor Author

I think new the top priority is for new versions of grunt-karma to support the newest versions of karma-runner. For most cases that is enough. There may be circumstances where mixing versions is needed, but I don't think the extra work is justified compared to other priorities.

Krinkle added a commit that referenced this issue Aug 29, 2018
@Krinkle
feat(karma): require karma 3 in peerDependencies
37d12b5 
The next release of grunt-karma will not support being used as
wrapper to run karma 1 or older.

Ref #261.
Krinkle added a commit that referenced this issue Aug 29, 2018
@Krinkle
feat(karma): require karma 3 in peerDependencies
2e04ccb 
The next release of grunt-karma will not support being used as
wrapper to run karma 1 or older.

This follows 19551fd which updates the tests to use karma 3.

Ref #261.
@Krinkle Krinkle mentioned this issue Aug 29, 2018
Merged
@johnjbarton
Copy link
Contributor Author

Sorry I can't get to this until ~24th. I tried today but ran into some issues with login and I will be out on vacation.

@johnjbarton
Copy link
Contributor Author

3.0 is up

@gkatsev gkatsev mentioned this issue Sep 11, 2018
Closed
Krinkle added a commit that referenced this issue Nov 21, 2018
@Krinkle
feat(karma): require karma 3 in peerDependencies
579f82f 
The next release of grunt-karma will not support being used as
wrapper to run karma 1 or older.

This follows 19551fd which updates the tests to use karma 3.

Ref #261.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnjbarton johnjbarton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Krinkle @johnjbarton