Implement flags for synchronizing the image list when changing the working directory #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having the working directory handler directly load the directory, we now defer this to the LibraryModel. This way, the model can decide if the path selected in the new directory is an image. If yes, load it - with this image focused. Thus, we don't end up jumping positions like previously, when we enter a directory that: * Has images * Has an image in the stored position Where: 1) We would load the directory into the library => paths visible in library 2) We would load the stored position => new path selected 3) We would load all images into the image filelist 4) We would open the first image 5) The library would select the first image => jump to new path which is not desirable
1) The stored path is an image => load images and select this one 2) There are images in the directory => load images and select the first image, overriding any stored directory 3) There are no images in the new directory => clear images This comes very close to the preferred behaviour in #132, except for the async part which we are omitting, in favour of the *optional* --open-selected flag.
This emulates the behaviour of :scroll left/right --open-selected by directly setting autoload in the library.
The image filelist should be empty when running :scroll left --open-selected and entering a directory without any images.
React to the emitted signal, instead of exclusively emitting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flags to syncrhonize the image file list when changing the working directory:
:scroll left/right --open-selectedfor the library as discussed in First image in directory not shown #694 along with the keybindings<ctrl>h/j/k/l.:open PATH[s] --open-imagesfor the:opencommand to mimic the behaviour, getting closer to Reload image/thumbnail mode when working directory changes #132.I believe this is as close as we will get to the ideas in #132 without going full-on async - which probably won't happen anytime soon (ever? 😢 ) given the time constraints for working on vimiv.
The odd outliers are when the image filelist is not in sync with a directory, e.g., when loading tags or opening images from multiple directories. However, this is not something the library (or opening a directory) would care about and sits on the other end of the spectrum.
Anyone still interested in testing this after such a long time? @mcp292 or @jcjgraf ? 😊
fixes #694 - along with the inconsistency noticed on initial testing ~7 months ago
fixes #132 - as we realistically won't go further into the async realm