Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic lookup is executed for every call to Publisher#publish #35

Open
brandonc opened this issue Jan 31, 2016 · 1 comment
Open

Topic lookup is executed for every call to Publisher#publish #35

brandonc opened this issue Jan 31, 2016 · 1 comment

Comments

@brandonc
Copy link
Contributor

brandonc commented Jan 31, 2016

https://github.com/kapost/circuitry/blob/master/lib/circuitry/publisher.rb#L64

Seems like we should have some topic ARN cache.

@aemadrid
Copy link

This seems like a bottleneck to publishing. Unless I'm missing something it is sending a create topic request for every single publish call. By having an arn cache we can skip creating on each request and then we can catch the exception for a missing topic and recreate it or bubble up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants