Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about VDA_FLOP Deletions #42

Open
Antti-L opened this issue May 22, 2024 · 2 comments
Open

Question about VDA_FLOP Deletions #42

Antti-L opened this issue May 22, 2024 · 2 comments
Assignees

Comments

@Antti-L
Copy link

Antti-L commented May 22, 2024

I only just now realized that the deletion of any VDA_FLOPs defined for PCG members no longer causes any warnings. And I also realize that defining VDA_FLOP for a PCG member no longer seems to works even in scenario files (it did work under VEDA-FE). Again, no warning or error appears to be issued by VEDA2 about such parameters. I tried to check with Browse, and then double and triple check from the deletion logs (step1, step2), but found no trace of them anywhere...

Could the developers please just confirm whether these changes are intentional? I would think the very silent deletion might potentially cause some confusion. As to the removed support in scenario files, I am OK with that change (because ACT_FLO gives that functionality, if needed).

@akanudia akanudia assigned akanudia and rohitkanors and unassigned akanudia May 23, 2024
@akanudia
Copy link
Contributor

akanudia commented May 23, 2024

Thanks for pointing this out @Antti-L . Our recent enhancements of the Sync log has had some unintended consequences. We also see spurious "no data was generated" warnings in some cases. We will address this in the next update.

@Antti-L
Copy link
Author

Antti-L commented Nov 1, 2024

I can see that with the new release candidates for v3.1.4, there can be a huge amount of log entries generated for VDA_FLOPs that have been deleted (delete_log_step2). Just in case someone might think that it was me who requested that, I would like to clarify that my request was to have log entries generated only when the VDA_FLOP might also have been expected to have some effect, i.e. when VDA_FLOP<>1 has been defined for a member of the PCG, like it was under VEDA-FE, and which was quite useful.

But now in the release candidate v3.1.4.8, all the VDA_FLOP=1 are also causing delete log entries, which in my view may not be very useful. And I cannot see any easy way to filter out the important cases of VDA_FLOP<>1, if any, from the long list of deletions generated. Under VEDA-FE I could immediately see a list of those important cases only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants