From e2ee7ce49dca1f9e61b50a5d0be2eb5a52f2ef94 Mon Sep 17 00:00:00 2001 From: Rahul M Chheda Date: Thu, 6 Aug 2020 13:37:30 +0530 Subject: [PATCH] Fixed review comments Signed-off-by: Rahul M Chheda --- pkg/param/param_test.go | 5 ----- pkg/resource/resource_test.go | 16 ++++++++-------- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/pkg/param/param_test.go b/pkg/param/param_test.go index e329f037e5c..4c03dff3e2d 100644 --- a/pkg/param/param_test.go +++ b/pkg/param/param_test.go @@ -578,11 +578,6 @@ func (s *ParamsSuite) TestProfile(c *C) { }, }, } - // asList := &crv1alpha1.ActionSetList{ - // Items: []*crv1alpha1.ActionSet{ - // as, - // }, - // } crCli := crfake.NewSimpleClientset() _, err = crCli.CrV1alpha1().ActionSets(s.namespace).Create(context.TODO(), as, metav1.CreateOptions{}) c.Assert(err, IsNil) diff --git a/pkg/resource/resource_test.go b/pkg/resource/resource_test.go index ee186661f52..45491110b35 100644 --- a/pkg/resource/resource_test.go +++ b/pkg/resource/resource_test.go @@ -85,19 +85,19 @@ func (s *ResourceSuite) TestActionSetClient(c *C) { c.Assert(as1, DeepEquals, as2) as2.Spec = &crv1alpha1.ActionSetSpec{} - as3, err := cli.ActionSets(s.namespace).Update(context.TODO(), as2, metav1.UpdateOptions{}) + as3, err := cli.ActionSets(s.namespace).Update(ctx, as2, metav1.UpdateOptions{}) c.Assert(err, IsNil) c.Assert(as1.Spec, IsNil) c.Assert(as3.Spec, NotNil) - as4, err := cli.ActionSets(s.namespace).Get(context.TODO(), name, emptyGetOptions) + as4, err := cli.ActionSets(s.namespace).Get(ctx, name, emptyGetOptions) c.Assert(err, IsNil) c.Assert(as4, DeepEquals, as3) - err = cli.ActionSets(s.namespace).Delete(context.TODO(), name, metav1.DeleteOptions{}) + err = cli.ActionSets(s.namespace).Delete(ctx, name, metav1.DeleteOptions{}) c.Assert(err, IsNil) - _, err = cli.ActionSets(s.namespace).Get(context.TODO(), name, emptyGetOptions) + _, err = cli.ActionSets(s.namespace).Get(ctx, name, emptyGetOptions) c.Assert(err, NotNil) } @@ -126,18 +126,18 @@ func (s *ResourceSuite) TestBlueprintClient(c *C) { c.Assert(bp1, DeepEquals, bp2) bp2.Actions = map[string]*crv1alpha1.BlueprintAction{} - bp3, err := cli.Blueprints(s.namespace).Update(context.TODO(), bp2, metav1.UpdateOptions{}) + bp3, err := cli.Blueprints(s.namespace).Update(ctx, bp2, metav1.UpdateOptions{}) c.Assert(err, IsNil) c.Assert(bp1.Actions, IsNil) c.Assert(bp3.Actions, NotNil) - bp4, err := cli.Blueprints(s.namespace).Get(context.TODO(), name, emptyGetOptions) + bp4, err := cli.Blueprints(s.namespace).Get(ctx, name, emptyGetOptions) c.Assert(err, IsNil) c.Assert(bp4, DeepEquals, bp3) - err = cli.Blueprints(s.namespace).Delete(context.TODO(), name, metav1.DeleteOptions{}) + err = cli.Blueprints(s.namespace).Delete(ctx, name, metav1.DeleteOptions{}) c.Assert(err, IsNil) - _, err = cli.Blueprints(s.namespace).Get(context.TODO(), name, emptyGetOptions) + _, err = cli.Blueprints(s.namespace).Get(ctx, name, emptyGetOptions) c.Assert(err, NotNil) }